Raise an exception if test data or crash reports can't be copied off a device

ios/build/bots/scripts/test_runner.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Test runners for iOS."""
 
 import argparse
 import collections
 import errno
 import os
@@ skipping 53 matching lines @@
       'PlugIns directory does not exist: %s' % plugins_dir)
 
 
 class SimulatorNotFoundError(TestRunnerError):
   """The given simulator binary was not found."""
   def __init__(self, iossim_path):
     super(SimulatorNotFoundError, self).__init__(
         'Simulator does not exist: %s' % iossim_path)
 
 
+class TestDataExtractionError(TestRunnerError):
+  """Error extracting test data or crash reports from a device."""
+  def __init__(self):
+    super(TestDataExtractionError, self).__init__('Failed to extract test data')
+
+
 class XcodeVersionNotFoundError(TestRunnerError):
   """The requested version of Xcode was not found."""
   def __init__(self, xcode_version):
     super(XcodeVersionNotFoundError, self).__init__(
         'Xcode version not found: %s', xcode_version)
 
 
 class XCTestPlugInNotFoundError(TestRunnerError):
   """The .xctest PlugIn was not found."""
   def __init__(self, xctest_path):
@@ skipping 510 matching lines @@
     subprocess.check_call(
       ['ideviceinstaller', '--udid', self.udid, '--install', self.app_path])
 
   def set_up(self):
     """Performs setup actions which must occur prior to every test launch."""
     self.uninstall_apps()
     self.install_app()
 
   def extract_test_data(self):
     """Extracts data emitted by the test."""
-    subprocess.check_call([
-      'idevicefs',
-      '--udid', self.udid,
-      'pull',
-      '@%s/Documents' % self.cfbundleid,
-      os.path.join(self.out_dir, 'Documents'),
-    ])
+    try:
+      subprocess.check_call([
+        'idevicefs',
+        '--udid', self.udid,
+        'pull',
+        '@%s/Documents' % self.cfbundleid,
+        os.path.join(self.out_dir, 'Documents'),
+      ])
+    except subprocess.CalledProcessError:
+      raise TestDataExtractionError()
 
   def retrieve_crash_reports(self):
     """Retrieves crash reports produced by the test."""
     logs_dir = os.path.join(self.out_dir, 'Logs')
     os.mkdir(logs_dir)
-    subprocess.check_call([
-      'idevicecrashreport',
-      '--extract',
-      '--udid', self.udid,
-      logs_dir,
-    ])
+    try:
+      subprocess.check_call([
+        'idevicecrashreport',
+        '--extract',
+        '--udid', self.udid,
+        logs_dir,
+      ])
+    except subprocess.CalledProcessError:
+      raise TestDataExtractionError()
 
   def tear_down(self):
     """Performs cleanup actions which must occur after every test launch."""
+    self.screenshot_desktop()
     self.extract_test_data()
     self.retrieve_crash_reports()
-    self.screenshot_desktop()
     self.uninstall_apps()
 
   def get_launch_command(self, test_filter=None, invert=False):
     """Returns the command that can be used to launch the test app.
 
     Args:
       test_filter: List of test cases to filter.
       invert: Whether to invert the filter or not. Inverted, the filter will
         match everything except the given test cases.
 
@@ skipping 41 matching lines @@
     """
     env = super(DeviceTestRunner, self).get_launch_env()
     if self.xctest_path:
       env['NSUnbufferedIO'] = 'YES'
       # e.g. ios_web_shell_egtests
       env['APP_TARGET_NAME'] = os.path.splitext(
           os.path.basename(self.app_path))[0]
       # e.g. ios_web_shell_egtests_module
       env['TEST_TARGET_NAME'] = env['APP_TARGET_NAME'] + '_module'
     return env