Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2618143003: Fix for travis (Closed)

Created:
3 years, 11 months ago by vsm
Modified:
3 years, 11 months ago
Reviewers:
Bob Nystrom, Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for travis Seeing a break on runhooks after the switch to GN (I think). We don't actually need to runhooks if we're not doing a full SDK build - except for pulling unittest. For the full build config, falling back to GYP for now. TBR=rnystrom@google.com,whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/c1725c5b7fa3c9aa6c9d57313e1f715f77e925c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M .travis.yml View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
Committed patchset #1 (id:1) manually as c1725c5b7fa3c9aa6c9d57313e1f715f77e925c1 (presubmit successful).
3 years, 11 months ago (2017-01-07 15:33:41 UTC) #2
Bill Hesse
lgtm
3 years, 11 months ago (2017-01-09 09:31:27 UTC) #3
Bob Nystrom
3 years, 11 months ago (2017-01-09 19:20:02 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698