Animate IOS Share extension button.

ios/chrome/share_extension/share_extension_view.mm

Index: ios/chrome/share_extension/share_extension_view.mm
diff --git a/ios/chrome/share_extension/share_extension_view.mm b/ios/chrome/share_extension/share_extension_view.mm
index ad47be843918cc721061d9052f9dd5986badf103..e3becd14b0c105964049cd5650e1cd61bafa5e3c 100644
--- a/ios/chrome/share_extension/share_extension_view.mm
+++ b/ios/chrome/share_extension/share_extension_view.mm
@@ -51,11 +51,16 @@ const CGFloat kButtonFontSize = 17;
 
 @interface ShareExtensionView () {
   __weak id<ShareExtensionViewActionTarget> _target;
+
+  // Track if a button has been pressed. All button pressing will have no effect
+  // if |_dismissed| is YES.
+  BOOL _dismissed;
 }
 
 // Keep strong references of the views that need to be updated.
 @property(nonatomic, strong) UILabel* titleLabel;
 @property(nonatomic, strong) UILabel* URLLabel;
+@property(nonatomic, strong) UIButton* readingListButton;
 @property(nonatomic, strong) UIImageView* screenshotView;
 @property(nonatomic, strong) UIStackView* itemStack;
 
@@ -74,12 +79,22 @@ const CGFloat kButtonFontSize = 17;
 // Returns a navigationBar.
 - (UINavigationBar*)navigationBar;
 
+// Called when "Read Later" button has been pressed.
+- (void)addToReadingListPressed:(UIButton*)sender;
+
+// Called when "Add to bookmarks" button has been pressed.
+- (void)addToBookmarksPressed:(UIButton*)sender;
+
+// Called when "Cancel" button has been pressed.
+- (void)cancelPressed:(UIButton*)sender;
+
 @end
 
 @implementation ShareExtensionView
 
 @synthesize titleLabel = _titleLabel;
 @synthesize URLLabel = _URLLabel;
+@synthesize readingListButton = _readingListButton;
 @synthesize screenshotView = _screenshotView;
 @synthesize itemStack = _itemStack;
 
@@ -91,6 +106,7 @@ const CGFloat kButtonFontSize = 17;
   if (self) {
     DCHECK(target);
     _target = target;
+    _dismissed = NO;
 
     [self.layer setCornerRadius:kCornerRadius];
     [self setClipsToBounds:YES];
@@ -112,22 +128,21 @@ const CGFloat kButtonFontSize = 17;
     NSString* addToReadingListTitle = NSLocalizedString(
         @"IDS_IOS_ADD_READING_LIST_SHARE_EXTENSION",
         @"The add to reading list button text in share extension.");
-    UIButton* readingListButton = [self
-        buttonWithTitle:addToReadingListTitle
-               selector:@selector(
-                            shareExtensionViewDidSelectAddToReadingList:)];
+    self.readingListButton =
+        [self buttonWithTitle:addToReadingListTitle
+                     selector:@selector(addToReadingListPressed:)];
 
     NSString* addToBookmarksTitle = NSLocalizedString(
         @"IDS_IOS_ADD_BOOKMARKS_SHARE_EXTENSION",
         @"The Add to bookmarks button text in share extension.");
-    UIButton* bookmarksButton = [self
-        buttonWithTitle:addToBookmarksTitle
-               selector:@selector(shareExtensionViewDidSelectAddToBookmarks:)];
+    UIButton* bookmarksButton =
+        [self buttonWithTitle:addToBookmarksTitle
+                     selector:@selector(addToBookmarksPressed:)];
 
     UIStackView* contentStack = [[UIStackView alloc] initWithArrangedSubviews:@[
       [self navigationBar], [self dividerViewWithVibrancy:vibrancyEffect],
       [self sharedItemView], [self dividerViewWithVibrancy:vibrancyEffect],
-      readingListButton, [self dividerViewWithVibrancy:vibrancyEffect],
+      self.readingListButton, [self dividerViewWithVibrancy:vibrancyEffect],
       bookmarksButton
     ]];
     [contentStack setAxis:UILayoutConstraintAxisVertical];
@@ -256,7 +271,7 @@ const CGFloat kButtonFontSize = 17;
   [button setTitleColor:systemColor forState:UIControlStateNormal];
   [[button titleLabel] setFont:[UIFont systemFontOfSize:kButtonFontSize]];
   [button setTranslatesAutoresizingMaskIntoConstraints:NO];
-  [button addTarget:_target
+  [button addTarget:self
                 action:selector
       forControlEvents:UIControlEventTouchUpInside];
   [button.heightAnchor constraintEqualToConstant:kButtonHeight].active = YES;
@@ -281,9 +296,8 @@ const CGFloat kButtonFontSize = 17;
 
   UIBarButtonItem* cancelButton = [[UIBarButtonItem alloc]
       initWithBarButtonSystemItem:UIBarButtonSystemItemCancel
-                           target:_target
-                           action:@selector(
-                                      shareExtensionViewDidSelectCancel:)];
+                           target:self
+                           action:@selector(cancelPressed:)];
 
   NSString* appName =
       [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleDisplayName"];
@@ -295,6 +309,93 @@ const CGFloat kButtonFontSize = 17;
   return navigationBar;
 }
 
+- (void)addToReadingListPressed:(UIButton*)sender {
+  if (_dismissed) {
+    return;
+  }
+  _dismissed = YES;
+  [self animateButtonPressed:sender
+              withCompletion:^{
+                [_target shareExtensionViewDidSelectAddToReadingList:sender];
+              }];
+}
+
+- (void)animateButtonPressed:(UIButton*)sender

[gambard, 2017/01/06 16:23:54]

Add method definition and comment.

[Olivier, 2017/01/06 16:42:16]

Done.

+              withCompletion:(void (^)(void))completion {
+  NSString* addedString =
+      NSLocalizedString(@"IDS_IOS_ADDED_ITEM_SHARE_EXTENSION",

[gambard, 2017/01/06 16:23:54]

Did you add IDS_IOS_ADDED_ITEM_SHARE_EXTENSION? I don't see it.

[Olivier, 2017/01/06 16:42:15]

I did... in another tree... :(

+                        @"Button label after being pressed.");
+  NSString* addedCheckedString =
+      [addedString stringByAppendingString:@" \u2713"];
+  // Create a label with the same style as the split animation between the text
+  // and the checkmark.
+  UILabel* addedLabel = [[UILabel alloc] initWithFrame:CGRectZero];
+  [addedLabel setTranslatesAutoresizingMaskIntoConstraints:NO];
+  [addedLabel setText:addedString];
+  [self addSubview:addedLabel];
+  [addedLabel setFont:[sender titleLabel].font];
+  [addedLabel setTextColor:[sender titleLabel].textColor];

[gambard, 2017/01/06 16:23:54]

You can use [sender titleColorForState:UIControlStateNormal];

[Olivier, 2017/01/06 16:42:15]

Done.

+  [addedLabel.leadingAnchor

[gambard, 2017/01/06 16:23:54]

This will align the beginning of the "Added" with the previous text of the
button.
Don't we want to center it?
You will need to change the way you are doing step3 if you do like that.

[Olivier, 2017/01/06 16:42:15]

There is no mock on what is centered.
What is true is that both labels must be aligned by leading as text of the
second must be just over the text of the first.

+      constraintEqualToAnchor:[sender titleLabel].leadingAnchor]
+      .active = YES;
+  [addedLabel.centerYAnchor
+      constraintEqualToAnchor:[sender titleLabel].centerYAnchor]
+      .active = YES;
+  [addedLabel setAlpha:0];
+
+  void (^step3ShowCheck)() = ^{
+    [UIView animateWithDuration:ui_util::kAnimationDuration
+        animations:^{
+          [addedLabel setAlpha:0];
+          [sender setAlpha:1];
+        }
+        completion:^(BOOL finished) {
+          completion();

[gambard, 2017/01/06 16:23:54]

You don't check for nullability?

[Olivier, 2017/01/06 16:42:16]

Done.

+        }];
+  };
+
+  void (^step2ShowTextWithoutCheck)() = ^{
+    [sender setTitle:addedCheckedString forState:UIControlStateNormal];
+    [UIView animateWithDuration:ui_util::kAnimationDuration
+        animations:^{
+          [addedLabel setAlpha:1];
+        }
+        completion:^(BOOL finished) {
+          step3ShowCheck();
+        }];
+  };
+
+  void (^step1HideText)() = ^{
+    [UIView animateWithDuration:ui_util::kAnimationDuration
+        animations:^{
+          [sender setAlpha:0];
+        }
+        completion:^(BOOL finished) {
+          step2ShowTextWithoutCheck();
+        }];
+  };
+  step1HideText();
+}
+
+- (void)addToBookmarksPressed:(UIButton*)sender {

[gambard, 2017/01/06 16:23:54]

Please position this function before animateButtonPressed:withCompletion:

[Olivier, 2017/01/06 16:42:16]

Done.

+  if (_dismissed) {
+    return;
+  }
+  _dismissed = YES;
+  [self animateButtonPressed:sender
+              withCompletion:^{
+                [_target shareExtensionViewDidSelectAddToBookmarks:sender];
+              }];
+}
+
+- (void)cancelPressed:(UIButton*)sender {
+  if (_dismissed) {
+    return;
+  }
+  _dismissed = YES;
+  [_target shareExtensionViewDidSelectCancel:sender];
+}
+
 #pragma mark - Content getters and setters.
 
 - (void)setURL:(NSURL*)URL {