pkg/kernel/lib/text/ast_to_text.dart - Issue 2617973002: Print <<NULL>> instead of crashing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/kernel/lib/text/ast_to_text.dart

Issue 2617973002: Print <<NULL>> instead of crashing. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/kernel/lib/text/ast_to_text.dart

diff --git a/pkg/kernel/lib/text/ast_to_text.dart b/pkg/kernel/lib/text/ast_to_text.dart

index 67152054b4815e247d9c792224d8dec5dd8df6d7..29602e609dda9f0702d8e27d0b5aab6f283a0ac8 100644

--- a/pkg/kernel/lib/text/ast_to_text.dart

+++ b/pkg/kernel/lib/text/ast_to_text.dart

@@ -393,7 +393,11 @@ class Printer extends Visitor<Null> {

}

void writeNode(Node node) {

- node.accept(this);

+ if (node == null) {

+ writeSymbol("<<NULL>>");

ahe 2017/01/06 15:32:31 Any suggestions for a better string to use here?

asgerf 2017/01/06 15:33:36 <Null> is consistent with what we write in default

ahe 2017/01/06 15:37:44 Done.

+ } else {

+ node.accept(this);

+ }

}

void writeOptionalNode(Node node) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »