Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2617963002: Option to include redirecting factories. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/fe_integration
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Changed upstream branch, no code changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -21 lines) Patch
M pkg/kernel/lib/analyzer/ast_from_analyzer.dart View 2 chunks +65 lines, -20 lines 0 comments Download
M pkg/kernel/lib/analyzer/loader.dart View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
ahe
3 years, 11 months ago (2017-01-06 14:55:23 UTC) #4
asgerf
Eugh. Can't say that it's pretty, but if it unblocks you then LGTM.
3 years, 11 months ago (2017-01-06 15:35:06 UTC) #5
ahe
On 2017/01/06 15:35:06, asgerf wrote: > Eugh. Can't say that it's pretty, but if it ...
3 years, 11 months ago (2017-01-06 15:38:45 UTC) #6
ahe
3 years, 11 months ago (2017-01-11 11:26:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
0ca41df321f405199c87d0f0b50043b8e8eaa99d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698