Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 26179004: Add code age subtype tracking to --track-gc-object-stats (Closed)

Created:
7 years, 2 months ago by rmcilroy
Modified:
7 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add code age subtype tracking to --track-gc-object-stats Adds counters which track the age of code in the heap during a gc if --track-gc-object-stats is enabled. - Splits RecordObjectStats into RecordObjectStats, RecordCodeSubTypeStats and RecordFixedArraySubTypeStats. - Renames kNoAge to kNoAgeCodeAge to follow other code age enums and enable the name to be used in Macro based initialization of the counters. BUG=None R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17369

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -52 lines) Patch
M src/arm/codegen-arm.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap.h View 1 2 1 chunk +21 lines, -17 lines 0 comments Download
M src/heap.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/mark-compact.cc View 1 6 chunks +17 lines, -24 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8-counters.h View 1 3 chunks +18 lines, -0 lines 0 comments Download
M src/v8-counters.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmcilroy
PTAL
7 years, 2 months ago (2013-10-11 19:00:19 UTC) #1
rmcilroy
On 2013/10/11 19:00:19, rmcilroy wrote: > PTAL Ping?
7 years, 2 months ago (2013-10-16 10:50:41 UTC) #2
rmcilroy
On 2013/10/16 10:50:41, rmcilroy wrote: > On 2013/10/11 19:00:19, rmcilroy wrote: > > PTAL > ...
7 years, 2 months ago (2013-10-22 09:24:33 UTC) #3
Hannes Payer (out of office)
LGTM
7 years, 2 months ago (2013-10-22 10:41:43 UTC) #4
rmcilroy
On 2013/10/22 10:41:43, Hannes Payer wrote: > LGTM Synced and rebased. Could you please land ...
7 years, 2 months ago (2013-10-22 11:37:10 UTC) #5
Hannes Payer (out of office)
7 years, 2 months ago (2013-10-24 10:50:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r17369 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698