Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1813)

Unified Diff: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc

Issue 2617883004: Initial UKMPageLoadMetricsObserver (Closed)
Patch Set: WIP Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..30608e8ec1b5537d289eeb13e8d6e504ae49f5c3
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
@@ -0,0 +1,63 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h"
+
+#include "base/memory/ptr_util.h"
+#include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h"
+
+namespace {
+
+const char kDefaultTestUrl[] = "https://google.com";
+
+} // namespace
+
+class UKMPageLoadMetricsObserverTest
+ : public page_load_metrics::PageLoadMetricsObserverTestHarness {
+ protected:
+ void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override {
+ tracker->AddObserver(
+ base::MakeUnique<ServiceWorkerPageLoadMetricsObserver>());
+ }
+
+ void SimulateTimingWithoutPaint() {
+ page_load_metrics::PageLoadTiming timing;
+ timing.navigation_start = base::Time::FromDoubleT(1);
+ SimulateTimingUpdate(timing);
+ }
+
+ void InitializeTestPageLoadTiming(page_load_metrics::PageLoadTiming* timing) {
+ timing->navigation_start = base::Time::FromDoubleT(1);
+ timing->parse_start = base::TimeDelta::FromMilliseconds(100);
+ timing->first_contentful_paint = base::TimeDelta::FromMilliseconds(300);
+ timing->dom_content_loaded_event_start =
+ base::TimeDelta::FromMilliseconds(600);
+ timing->load_event_start = base::TimeDelta::FromMilliseconds(1000);
+ PopulateRequiredTimingFields(timing);
+ }
+};
+
+TEST_F(UKMPageLoadMetricsObserverTest, NoMetrics) {
+ AssertNoServiceWorkerHistogramsLogged();
+ AssertNoInboxHistogramsLogged();
+}
+
+TEST_F(UKMPageLoadMetricsObserverTest, NoServiceWorker) {
+ page_load_metrics::PageLoadTiming timing;
+ InitializeTestPageLoadTiming(&timing);
+
+ NavigateAndCommit(GURL(kDefaultTestUrl));
+ SimulateTimingUpdate(timing);
+
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramServiceWorkerFirstContentfulPaintInbox, 0);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramServiceWorkerParseStartToFirstContentfulPaintInbox,
+ 0);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramServiceWorkerDomContentLoadedInbox, 0);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramServiceWorkerLoadInbox, 0);
+}
+

Powered by Google App Engine
This is Rietveld 408576698