Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(393)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: components/ukm/DEPS
Issue
2617883004
:
Initial UKMPageLoadMetricsObserver (Closed)
Patch Set: Class rename
Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/BUILD.gn
chrome/browser/browser_process.h
chrome/browser/browser_process_impl.h
chrome/browser/browser_process_impl.cc
chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
chrome/test/BUILD.gn
chrome/test/base/testing_browser_process.h
chrome/test/base/testing_browser_process.cc
components/metrics/proto/ukm/source.proto
components/ukm/BUILD.gn
components/ukm/DEPS
components/ukm/test_ukm_service.h
components/ukm/test_ukm_service.cc
components/ukm/ukm_service.h
components/ukm/ukm_service.cc
components/ukm/ukm_service_unittest.cc
components/ukm/ukm_source.h
components/ukm/ukm_source.cc
View unified diff
|
Download patch
« chrome/test/base/testing_browser_process.cc
('K') |
« components/ukm/BUILD.gn
('k') |
components/ukm/test_ukm_service.h »
('j') |
components/ukm/ukm_source.h »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2 "+components/metrics",
2 "+components/metrics",
3 "+components/prefs",
3 "+components/prefs",
4 "+components/variations",
4 "+components/variations",
5
"+third_party/zlib/google",
5 ]
6 ]
OLD
NEW
« chrome/test/base/testing_browser_process.cc
('K') |
« components/ukm/BUILD.gn
('k') |
components/ukm/test_ukm_service.h »
('j') |
components/ukm/ukm_source.h »
('J')
Issue 2617883004: Initial UKMPageLoadMetricsObserver (Closed)
Created 3 years, 11 months ago by oystein (OOO til 10th of July)
Modified 3 years, 10 months ago
Reviewers: Bryan McQuade, Steven Holte, Zhen Wang
Base URL:
Comments: 17
This is Rietveld
408576698