Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: services/service_manager/public/interfaces/connector.mojom

Issue 2617883002: Add a new BindInterface() method to Connector. (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/public/interfaces/connector.mojom
diff --git a/services/service_manager/public/interfaces/connector.mojom b/services/service_manager/public/interfaces/connector.mojom
index bff2cf0f242a8f8df7c5cf1ed11aa084deb10974..3c759cbbe918aed432832f5f394aaecb49319f67 100644
--- a/services/service_manager/public/interfaces/connector.mojom
+++ b/services/service_manager/public/interfaces/connector.mojom
@@ -88,9 +88,9 @@ interface Connector {
// the process it created (the pid isn't supplied directly here as the
// process may not have been launched by the time Connect() is called.)
//
- Start(Identity name,
- handle<message_pipe> service,
- PIDReceiver& pid_receiver_request);
+ StartService(Identity name,
+ handle<message_pipe> service,
+ PIDReceiver& pid_receiver_request);
// Requests a connection with another service. The service originating the
// request is referred to as the "source" and the one receiving the "target".
@@ -129,6 +129,15 @@ interface Connector {
Connect(Identity target, InterfaceProvider&? remote_interfaces) =>
(ConnectResult result, string user_id);
+ // Variant of Connect() above. Will (gradually) replace it. Think of this like
+ // a combination of Connect() and InterfaceProvider::GetInteface() - requests
+ // a connection to a service and binds an interface in one step.
+ // TODO(beng): Update this comment once the implementation is complete.
+ BindInterface(Identity target,
+ string interface_name,
+ handle<message_pipe> interface_pipe) =>
+ (ConnectResult result, string user_id);
+
// Clones this Connector so it can be passed to another thread.
Clone(Connector& request);
};
« no previous file with comments | « services/service_manager/public/cpp/lib/connector_impl.cc ('k') | services/service_manager/service_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698