[Cronet] Use CookieStoreIOS to sync cookies to system store.

components/cronet/ios/test/cronet_http_test.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cronet/Cronet.h>
 #import <Foundation/Foundation.h>
 
 #include <stdint.h>
 
 #include "base/logging.h"
@@ skipping 240 matching lines @@
   [Cronet setRequestFilterBlock:nil];
   NSURLSessionDataTask* task = [session_ dataTaskWithURL:url];
   StartDataTaskAndWaitForCompletion(task);
   EXPECT_EQ(nil, [delegate_ error]);
   EXPECT_STREQ(kUserAgent, [[delegate_ responseBody] UTF8String]);
 }
 
 TEST_F(HttpTest, SetCookie) {
   const char kCookieHeader[] = "Cookie";
   const char kCookieLine[] = "aaaa=bbb";
-  NSURL* echoCookieUrl =
+  NSHTTPCookieStorage* systemCookieStorage =
+      [NSHTTPCookieStorage sharedHTTPCookieStorage];
+  NSURL* cookieUrl =
       net::NSURLWithGURL(GURL(TestServer::GetEchoHeaderURL(kCookieHeader)));
-  StartDataTaskAndWaitForCompletion([session_ dataTaskWithURL:echoCookieUrl]);
+  // Verify that cookie is not set in system storage.
+  for (NSHTTPCookie* cookie in [systemCookieStorage cookiesForURL:cookieUrl]) {
+    EXPECT_FALSE([[cookie name] isEqualToString:@"aaaa"]);
+  }
+
+  StartDataTaskAndWaitForCompletion([session_ dataTaskWithURL:cookieUrl]);
   EXPECT_EQ(nil, [delegate_ error]);
   EXPECT_EQ(nil, [delegate_ responseBody]);
 
   NSURL* setCookieUrl =
       net::NSURLWithGURL(GURL(TestServer::GetSetCookieURL(kCookieLine)));
   StartDataTaskAndWaitForCompletion([session_ dataTaskWithURL:setCookieUrl]);
   EXPECT_EQ(nil, [delegate_ error]);
   EXPECT_TRUE([[delegate_ responseBody]
       containsString:base::SysUTF8ToNSString(kCookieLine)]);
 
-  StartDataTaskAndWaitForCompletion([session_ dataTaskWithURL:echoCookieUrl]);
+  StartDataTaskAndWaitForCompletion([session_ dataTaskWithURL:cookieUrl]);
   EXPECT_EQ(nil, [delegate_ error]);
   EXPECT_TRUE([[delegate_ responseBody]
       containsString:base::SysUTF8ToNSString(kCookieLine)]);
+
+  // Verify that cookie is set in system storage.
+  NSHTTPCookie* systemCookie = nil;
+  for (NSHTTPCookie* cookie in [systemCookieStorage cookiesForURL:cookieUrl]) {
+    if ([cookie.name isEqualToString:@"aaaa"]) {
+      systemCookie = cookie;
+      break;
+    }
+  }
+  EXPECT_TRUE([[systemCookie value] isEqualToString:@"bbb"]);
+  [systemCookieStorage deleteCookie:systemCookie];
+}
+
+TEST_F(HttpTest, SetSystemCookie) {
+  const char kCookieHeader[] = "Cookie";
+  NSHTTPCookieStorage* systemCookieStorage =
+      [NSHTTPCookieStorage sharedHTTPCookieStorage];
+  NSURL* echoCookieUrl =
+      net::NSURLWithGURL(GURL(TestServer::GetEchoHeaderURL(kCookieHeader)));
+  NSHTTPCookie* systemCookie = [NSHTTPCookie cookieWithProperties:@{
+    NSHTTPCookiePath : [echoCookieUrl path],
+    NSHTTPCookieName : @"cccc",
+    NSHTTPCookieValue : @"dddd",
+    NSHTTPCookieDomain : [echoCookieUrl host],
+  }];
+  [systemCookieStorage setCookie:systemCookie];
+
+  StartDataTaskAndWaitForCompletion([session_ dataTaskWithURL:echoCookieUrl]);
+  EXPECT_EQ(nil, [delegate_ error]);
+  // Verify that cookie set in system store was sent to the serever.
+  EXPECT_TRUE([[delegate_ responseBody] isEqualToString:@"cccc=dddd"]);

[kapishnikov, 2017/01/06 16:23:17]

I would use containsString here since the cookie header value may contain some
extra characters.

[mef, 2017/01/06 17:58:59]

Done.

+  [systemCookieStorage deleteCookie:systemCookie];

[kapishnikov, 2017/01/06 16:23:17]

If the above 'EXPECTs' fail, the cookie is not going to be deleted. As the
result, the test rerun may not test what we want, namely adding the cookie after
the chromium cookie store has been initialized. We should move 'deleteCookie'
up.

I am also thinking, maybe we should generate the cookie name and value randomly
with some predefined prefix. Thus, we can guarantee that the test will not be
impacted by some residual values.

[mef, 2017/01/06 17:58:59]

Done.

 }
 
 TEST_F(HttpTest, FilterOutRequest) {
   NSURL* url =
       net::NSURLWithGURL(GURL(TestServer::GetEchoHeaderURL("User-Agent")));
   __block BOOL block_used = NO;
   NSURLSessionDataTask* task = [session_ dataTaskWithURL:url];
   [Cronet setRequestFilterBlock:^(NSURLRequest* request) {
     block_used = YES;
     EXPECT_EQ([request URL], url);
     return NO;
   }];
   StartDataTaskAndWaitForCompletion(task);
   EXPECT_TRUE(block_used);
   EXPECT_EQ(nil, [delegate_ error]);
   EXPECT_FALSE([[delegate_ responseBody]
       containsString:base::SysUTF8ToNSString(kUserAgent)]);
   EXPECT_TRUE([[delegate_ responseBody] containsString:@"CFNetwork"]);
 }
 
 }  // namespace cronet