[Cronet] Use CookieStoreIOS to sync cookies to system store.

components/cronet/ios/test/cronet_http_test.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cronet/Cronet.h>
 #import <Foundation/Foundation.h>
 
 #include <stdint.h>
 
 #include "base/logging.h"
@@ skipping 240 matching lines @@
   [Cronet setRequestFilterBlock:nil];
   NSURLSessionDataTask* task = [session_ dataTaskWithURL:url];
   StartDataTaskAndWaitForCompletion(task);
   EXPECT_EQ(nil, [delegate_ error]);
   EXPECT_STREQ(kUserAgent, [[delegate_ responseBody] UTF8String]);
 }
 
 TEST_F(HttpTest, SetCookie) {
   const char kCookieHeader[] = "Cookie";
   const char kCookieLine[] = "aaaa=bbb";
+  NSHTTPCookieStorage* systemCookieStorage =
+      [NSHTTPCookieStorage sharedHTTPCookieStorage];
+  NSURL* cookieUrl =
+      [NSURL URLWithString:base::SysUTF8ToNSString(
+                               TestServer::GetEchoHeaderURL(kCookieHeader))];
+  // Verify that cookie is not set in system storage.
+  for (NSHTTPCookie* cookie in [systemCookieStorage cookiesForURL:cookieUrl]) {
+    EXPECT_FALSE([[cookie name] containsString:@"aaaa"]);

[kapishnikov, 2017/01/06 15:24:45]

Since 'isEqual' (or better 'isEqualToString') is used to search for the cookie
below, I would suggest using the same method here for symmetry.

[mef, 2017/01/06 15:52:55]

Done.

+  }
+
   NSURL* echoCookieUrl =
       net::NSURLWithGURL(GURL(TestServer::GetEchoHeaderURL(kCookieHeader)));
   StartDataTaskAndWaitForCompletion([session_ dataTaskWithURL:echoCookieUrl]);
   EXPECT_EQ(nil, [delegate_ error]);
   EXPECT_EQ(nil, [delegate_ responseBody]);
 
   NSURL* setCookieUrl =
       net::NSURLWithGURL(GURL(TestServer::GetSetCookieURL(kCookieLine)));
   StartDataTaskAndWaitForCompletion([session_ dataTaskWithURL:setCookieUrl]);
   EXPECT_EQ(nil, [delegate_ error]);
   EXPECT_TRUE([[delegate_ responseBody]
       containsString:base::SysUTF8ToNSString(kCookieLine)]);
 
   StartDataTaskAndWaitForCompletion([session_ dataTaskWithURL:echoCookieUrl]);
   EXPECT_EQ(nil, [delegate_ error]);
   EXPECT_TRUE([[delegate_ responseBody]
       containsString:base::SysUTF8ToNSString(kCookieLine)]);
+
+  // Verify that cookie is set in system storage.
+  NSHTTPCookie* systemCookie = nil;
+  for (NSHTTPCookie* cookie in [systemCookieStorage cookiesForURL:cookieUrl]) {
+    if ([cookie.name isEqual:@"aaaa"]) {

[kapishnikov, 2017/01/06 15:24:45]

isEqualToString should be a little faster.

[mef, 2017/01/06 15:52:55]

Done.

+      systemCookie = cookie;
+      break;
+    }
+  }
+  EXPECT_TRUE([[systemCookie value] containsString:@"bbb"]);

[kapishnikov, 2017/01/06 15:24:45]

Why don't use isEqualToString instead of containsString?

[mef, 2017/01/06 15:52:55]

Done.

+  [systemCookieStorage deleteCookie:systemCookie];
 }
 
 TEST_F(HttpTest, FilterOutRequest) {
   NSURL* url =
       net::NSURLWithGURL(GURL(TestServer::GetEchoHeaderURL("User-Agent")));
   __block BOOL block_used = NO;
   NSURLSessionDataTask* task = [session_ dataTaskWithURL:url];
   [Cronet setRequestFilterBlock:^(NSURLRequest* request) {
     block_used = YES;
     EXPECT_EQ([request URL], url);
     return NO;
   }];
   StartDataTaskAndWaitForCompletion(task);
   EXPECT_TRUE(block_used);
   EXPECT_EQ(nil, [delegate_ error]);
   EXPECT_FALSE([[delegate_ responseBody]
       containsString:base::SysUTF8ToNSString(kUserAgent)]);
   EXPECT_TRUE([[delegate_ responseBody] containsString:@"CFNetwork"]);
 }
 
 }  // namespace cronet