Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2617833002: Run AssistProcessor tests with the new analysis driver. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run AssistProcessor tests with the new analysis driver. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4e49205c617752f43916fd238d9dada7d87e8ac1

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -26 lines) Patch
M pkg/analysis_server/test/abstract_single_unit.dart View 3 chunks +21 lines, -8 lines 3 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 14 chunks +65 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 11 months ago (2017-01-05 22:43:42 UTC) #1
Brian Wilkerson
https://codereview.chromium.org/2617833002/diff/1/pkg/analysis_server/test/abstract_single_unit.dart File pkg/analysis_server/test/abstract_single_unit.dart (right): https://codereview.chromium.org/2617833002/diff/1/pkg/analysis_server/test/abstract_single_unit.dart#newcode112 pkg/analysis_server/test/abstract_single_unit.dart:112: error.errorCode != HintCode.UNUSED_LOCAL_VARIABLE; Why do we need to filter ...
3 years, 11 months ago (2017-01-06 00:01:40 UTC) #2
scheglov
https://codereview.chromium.org/2617833002/diff/1/pkg/analysis_server/test/abstract_single_unit.dart File pkg/analysis_server/test/abstract_single_unit.dart (right): https://codereview.chromium.org/2617833002/diff/1/pkg/analysis_server/test/abstract_single_unit.dart#newcode112 pkg/analysis_server/test/abstract_single_unit.dart:112: error.errorCode != HintCode.UNUSED_LOCAL_VARIABLE; On 2017/01/06 00:01:40, Brian Wilkerson wrote: ...
3 years, 11 months ago (2017-01-06 00:03:28 UTC) #3
Brian Wilkerson
lgtm https://codereview.chromium.org/2617833002/diff/1/pkg/analysis_server/test/abstract_single_unit.dart File pkg/analysis_server/test/abstract_single_unit.dart (right): https://codereview.chromium.org/2617833002/diff/1/pkg/analysis_server/test/abstract_single_unit.dart#newcode112 pkg/analysis_server/test/abstract_single_unit.dart:112: error.errorCode != HintCode.UNUSED_LOCAL_VARIABLE; Perhaps a comment to that ...
3 years, 11 months ago (2017-01-06 00:07:37 UTC) #4
scheglov
3 years, 11 months ago (2017-01-06 00:59:42 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4e49205c617752f43916fd238d9dada7d87e8ac1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698