Issue 261783008: Revert of Make SandboxIPCProcess a thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 261783008: Revert of Make SandboxIPCProcess a thread. (Closed)

Created:
6 years, 7 months ago by Lei Zhang

Modified:
6 years, 7 months ago

Reviewers:
Jorge Lucangeli Obes, jln (very slow on Chromium), piman

CC:
chromium-reviews, darin-cc_chromium.org, jam, Mark Mentovai

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Make SandboxIPCProcess a thread. (https://codereview.chromium.org/255693002/) Reason for revert: TSANv2 bot reports races on many many tests. Original issue's description: > Make SandboxIPCProcess a thread. > > BUG=322185 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267583 TBR=jln@chromium.org,piman@chromium.org,jorgelo@chromium.org NOTREECHECKS=true NOTRY=true BUG=322185 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267625

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -50 lines)			Patch
M	chrome/browser/memory_details.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_sandbox_host_linux.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/render_sandbox_host_linux.cc	View	2 chunks	+27 lines, -7 lines	0 comments	Download
M	content/browser/renderer_host/sandbox_ipc_linux.h	View	2 chunks	+13 lines, -7 lines	0 comments	Download
M	content/browser/renderer_host/sandbox_ipc_linux.cc	View	14 chunks	+39 lines, -30 lines	0 comments	Download
M	content/browser/zygote_host/zygote_host_impl_linux.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/zygote_host/zygote_host_impl_linux.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/public/browser/zygote_host_linux.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/261783008/1

6 years, 7 months ago (2014-05-01 20:39:52 UTC) #2

Message was sent while issue was closed.

Change committed as 267625