Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 261783005: Begins work on arm64 floating point instructions. (Closed)

Created:
6 years, 7 months ago by zra
Modified:
6 years, 7 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Begins work on arm64 floating point instructions. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35661

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+482 lines, -85 lines) Patch
M runtime/vm/assembler_arm64.h View 1 2 3 chunks +39 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64_test.cc View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M runtime/vm/constants_arm64.h View 1 2 8 chunks +53 lines, -1 line 0 comments Download
M runtime/vm/disassembler_arm64.cc View 1 2 7 chunks +109 lines, -21 lines 0 comments Download
M runtime/vm/parser_test.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm64.h View 1 2 4 chunks +19 lines, -1 line 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 2 12 chunks +188 lines, -59 lines 0 comments Download
M runtime/vm/unit_test.h View 1 2 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
6 years, 7 months ago (2014-05-01 20:42:35 UTC) #1
regis
LGTM
6 years, 7 months ago (2014-05-01 21:22:01 UTC) #2
zra
6 years, 7 months ago (2014-05-01 21:50:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r35661 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698