Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 261783004: Add flag for SkGpuSurface creation to enable distance fields. (Closed)

Created:
6 years, 7 months ago by jvanverth1
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add flag for SkGpuSurface creation to enable distance fields. BUG=skia:2173 Committed: http://code.google.com/p/skia/source/detail?r=14525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -21 lines) Patch
M include/core/SkSurface.h View 2 chunks +20 lines, -3 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/image/SkSurface_Gpu.cpp View 5 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jvanverth1
6 years, 7 months ago (2014-05-01 19:31:18 UTC) #1
bungeman-skia
The general idea lgtm.
6 years, 7 months ago (2014-05-01 19:46:20 UTC) #2
reed1
does vangelis already use surfaces for this? lgtm, though in the future we may want ...
6 years, 7 months ago (2014-05-01 20:29:15 UTC) #3
bsalomon
Overall lgtm. But I am wondering why we have a DF Text Context at all ...
6 years, 7 months ago (2014-05-01 20:31:03 UTC) #4
jvanverth1
On 2014/05/01 20:31:03, bsalomon wrote: > Overall lgtm. But I am wondering why we have ...
6 years, 7 months ago (2014-05-01 20:53:03 UTC) #5
bsalomon
On 2014/05/01 20:53:03, jvanverth1 wrote: > On 2014/05/01 20:31:03, bsalomon wrote: > > Overall lgtm. ...
6 years, 7 months ago (2014-05-01 20:56:35 UTC) #6
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 7 months ago (2014-05-02 12:33:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/261783004/1
6 years, 7 months ago (2014-05-02 12:33:25 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 12:39:43 UTC) #9
Message was sent while issue was closed.
Change committed as 14525

Powered by Google App Engine
This is Rietveld 408576698