Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: chromecast/media/cma/pipeline/media_pipeline_impl.cc

Issue 2617823003: [Chromecast] Make buffering logging less confusing (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/media/cma/pipeline/media_pipeline_impl.cc
diff --git a/chromecast/media/cma/pipeline/media_pipeline_impl.cc b/chromecast/media/cma/pipeline/media_pipeline_impl.cc
index 4000955562473c54b64a3c5b4b5a3c427b4b9f1c..2ec4901d3323150381b6ca02655b08b80a96330f 100644
--- a/chromecast/media/cma/pipeline/media_pipeline_impl.cc
+++ b/chromecast/media/cma/pipeline/media_pipeline_impl.cc
@@ -352,7 +352,7 @@ void MediaPipelineImpl::OnFlushDone(bool is_audio_stream) {
}
void MediaPipelineImpl::OnBufferingNotification(bool is_buffering) {
- CMALOG(kLogControl) << __FUNCTION__ << " is_buffering=" << is_buffering;
+ LOG(INFO) << __FUNCTION__ << " is_buffering=" << is_buffering;
alokp 2017/01/05 23:57:38 We should continue to use VLOG here.
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK((backend_state_ == BACKEND_STATE_PLAYING) ||
(backend_state_ == BACKEND_STATE_PAUSED));
@@ -364,7 +364,7 @@ void MediaPipelineImpl::OnBufferingNotification(bool is_buffering) {
// TODO(alokp): WebMediaPlayerImpl currently only handles HAVE_ENOUGH.
// See WebMediaPlayerImpl::OnPipelineBufferingStateChanged,
// http://crbug.com/144683.
- LOG(WARNING) << "Ignoring buffering notification.";
+ NOTIMPLEMENTED();
} else {
client_.buffering_state_cb.Run(::media::BUFFERING_HAVE_ENOUGH);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698