Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2686)

Unified Diff: chrome/browser/resources/feedback/js/feedback.js

Issue 2617823002: GRIT: put <if> and <include> behind comments in .js files to make syntactically valid JS (Closed)
Patch Set: add dep Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/feedback/js/feedback.js
diff --git a/chrome/browser/resources/feedback/js/feedback.js b/chrome/browser/resources/feedback/js/feedback.js
index ddb8685804db9f8ce0eceb812deeb36d823e1993..6d06cc7b812bf8418dbb35989fc5dd0e1e8bafd4 100644
--- a/chrome/browser/resources/feedback/js/feedback.js
+++ b/chrome/browser/resources/feedback/js/feedback.js
@@ -175,12 +175,12 @@ function sendReport() {
// Send histograms along with system info.
useSystemInfo = useHistograms = true;
}
-<if expr="chromeos">
+// <if expr="chromeos">
if ($('performance-info-checkbox') == null ||
!($('performance-info-checkbox').checked)) {
feedbackInfo.traceId = null;
}
-</if>
+// </if>
feedbackInfo.sendHistograms = useHistograms;
@@ -229,7 +229,7 @@ function dataUrlToBlob(url) {
return new Blob([new Uint8Array(dataArray)], {type: mimeString});
}
-<if expr="chromeos">
+// <if expr="chromeos">
/**
* Update the page when performance feedback state is changed.
*/
@@ -245,7 +245,7 @@ function performanceFeedbackChanged() {
$('screenshot-checkbox').disabled = false;
}
}
-</if>
+// </if>
function resizeAppWindow() {
// We pick the width from the titlebar, which has no margins.
@@ -367,14 +367,14 @@ function initialize() {
$('attach-file-note').hidden = true;
}
-<if expr="chromeos">
+// <if expr="chromeos">
if (feedbackInfo.traceId && ($('performance-info-area'))) {
$('performance-info-area').hidden = false;
$('performance-info-checkbox').checked = true;
performanceFeedbackChanged();
$('performance-info-link').onclick = openSlowTraceWindow;
}
-</if>
+// </if>
chrome.feedbackPrivate.getStrings(function(strings) {
loadTimeData.data = strings;
i18nTemplate.process(document, loadTimeData);
@@ -437,10 +437,10 @@ function initialize() {
$('send-report-button').onclick = sendReport;
$('cancel-button').onclick = cancel;
$('remove-attached-file').onclick = clearAttachedFile;
-<if expr="chromeos">
+// <if expr="chromeos">
$('performance-info-checkbox').addEventListener(
'change', performanceFeedbackChanged);
-</if>
+// </if>
});
}
« no previous file with comments | « chrome/browser/resources/feedback/js/event_handler.js ('k') | chrome/browser/resources/gaia_auth_host/authenticator.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698