Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2617803003: GN: Make GN the default (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: Make GN the default Ryan landed a fix for #28200 so we can try to land this again. Tests on Debug builds will be slower until https://codereview.chromium.org/2614003003/ lands, but we didn't notice an uptick in bot timeouts when we tried this before, so I suspect the bots will continue to be unaffected. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/632b74404626ff81fe8678f139b5b3b78a59dc51

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M tools/bots/gn_build.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/build.py View 4 chunks +8 lines, -8 lines 1 comment Download
M tools/generate_buildfiles.py View 4 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
3 years, 11 months ago (2017-01-06 18:28:14 UTC) #2
Bill Hesse
lgtm
3 years, 11 months ago (2017-01-06 23:24:13 UTC) #3
zra
Committed patchset #1 (id:1) manually as 632b74404626ff81fe8678f139b5b3b78a59dc51 (presubmit successful).
3 years, 11 months ago (2017-01-06 23:35:58 UTC) #5
Kevin Millikin (Google)
3 years, 11 months ago (2017-01-10 08:39:55 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2617803003/diff/1/tools/build.py
File tools/build.py (left):

https://codereview.chromium.org/2617803003/diff/1/tools/build.py#oldcode87
tools/build.py:87: result.add_option("--gn",
Just a comment: we didn't *have* to remove this flag for any reason.

Millions of scripts cried out in terror and were suddenly silenced.

Powered by Google App Engine
This is Rietveld 408576698