Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2617753002: [InputEvent] Move attributes from |EditCommand| to |CompositeEditCommand| (2/11) (Closed)

Created:
3 years, 11 months ago by chongz
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews, yosin_UTC9
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[InputEvent] Move attributes from |EditCommand| to |CompositeEditCommand| (2/11) This CL moved/added 4 |InputEvent| related attributes to |CompositeEditCommand|: 1. |inputType()| 2. |textDataForInputEvent()| 3. |dataTransferForInputEvent()| 4. |targetRangesForInputEvent()| And introduced utility |isComposingFromCommand()|. Reasoning: |CompositeEditCommand| is more suitable for |InputEvent| as we never fire 'beforeinput' from |SimpleEditCommand|. This CL doesn't have behavior change. Please see bug and the design doc below for the big picture: https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd4ZkgJs5GPde2ZsDy0/edit?usp=sharing BUG=678795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -23 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 2 chunks +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditCommand.h View 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditCommand.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (7 generated)
chongz
PTAL, thanks!
3 years, 11 months ago (2017-01-05 23:40:07 UTC) #7
Xiaocheng
lgtm +yosin
3 years, 11 months ago (2017-01-06 02:11:47 UTC) #9
chongz
3 years, 11 months ago (2017-01-09 23:41:13 UTC) #10
yosin@ PTAL, thanks!

Powered by Google App Engine
This is Rietveld 408576698