third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h - Issue 2617733004: binding: Changes the association among global-proxy/global/window-instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h

Issue 2617733004: binding: Changes the association among global-proxy/global/window-instance. (Closed)

Patch Set: Addressed review comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h b/third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h

index 3cbbca9e3d2c3e8d1546a782bdc88aec111e1ea1..6bf1f7582b9831153f5329f79df4999d48d1bdc4 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h

+++ b/third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h

@@ -79,13 +79,12 @@ class DOMWrapperMap {

return true;

}

- void clear() { m_map.Clear(); }

- void removeAndDispose(KeyType* key) {

- ASSERT(containsKey(key));

+ void removeIfAny(KeyType* key) {

m_map.Remove(key);

}

+ void clear() { m_map.Clear(); }

void markWrapper(KeyType* object) {

m_map.RegisterExternallyReferencedObject(object);

}