Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h

Issue 2617733004: binding: Changes the association among global-proxy/global/window-instance. (Closed)
Patch Set: Fixed Document.defaultView Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h b/third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h
index 3cbbca9e3d2c3e8d1546a782bdc88aec111e1ea1..5f73b74ce4f52e8e69128e86f7466a22775a5d07 100644
--- a/third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h
+++ b/third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h
@@ -79,13 +79,13 @@ class DOMWrapperMap {
return true;
}
- void clear() { m_map.Clear(); }
-
- void removeAndDispose(KeyType* key) {
- ASSERT(containsKey(key));
- m_map.Remove(key);
+ void removeIfAny(KeyType* key) {
+ if (containsKey(key))
haraken 2017/02/09 12:46:40 Nit: Do you need this check?
Yuki 2017/02/10 07:47:21 Seems not necessary. Removed.
+ m_map.Remove(key);
}
+ void clear() { m_map.Clear(); }
+
void markWrapper(KeyType* object) {
m_map.RegisterExternallyReferencedObject(object);
}

Powered by Google App Engine
This is Rietveld 408576698