[SVG2] css 'outline' property should apply to svg elements

[SVG2] css 'outline' property should apply to svg elements

The 'outline' property was only partially working in svg before this patch,
this makes it work on text and text content child elements too.

This makes SVG render the outlines as part of the foreground paint phase.

Partly based on Florin Malita's webkit patch https://bugs.webkit.org/show_bug.cgi?id=113666#c12.

BUG=369473
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174186

[krit, 2014-05-09 16:31:10]

On 2014/05/09 10:23:17, Erik Dahlström wrote:

I was skeptical about changing the way focus rings/outlines are drawn but think
that the new design is the right way to go now.

[pdr., 2014-05-09 18:56:39]

I think this looks reasonable. I'm a little worried about diverging from the
paintphases used in the rest of core/rendering but this patch looks good and
fixes several bugs.

https://codereview.chromium.org/261773008/diff/80001/Source/core/rendering/sv...
File Source/core/rendering/svg/RenderSVGContainer.cpp (right):

https://codereview.chromium.org/261773008/diff/80001/Source/core/rendering/sv...
Source/core/rendering/svg/RenderSVGContainer.cpp:154: // We should instead
disable our clip during PaintPhaseOutline
Does this comment need updating to no longer refer to PaintPhaseOutline?

As an aside, about the two spaces thing above: In schools in the united states,
anyone under about 30yrs (including me) was taught to add two spaces after a
period because it was easier to read on typewriters. This is no longer the case
with modern font rendering, but it's a hard habit to break :) We should
absolutely remove these when we see them, but that's how they crept into the
comments all over.

[f(malita), 2014-05-12 11:29:02]

lgtm

[krit, 2014-05-12 18:23:07]

On 2014/05/12 11:29:02, Florin Malita wrote:
> lgtm

It seems that there are repaint issues when selecting text and unselecting
again.

[Erik Dahlström (inactive), 2014-05-16 12:19:21]

On 2014/05/12 18:23:07, krit wrote:
> On 2014/05/12 11:29:02, Florin Malita wrote:
> > lgtm
> 
> It seems that there are repaint issues when selecting text and unselecting
> again.

Do you have any particular testcase that fails? Because I can't confirm that
finding in my local content_shell, tried with the existing layout tests both
with and without outline.

[Erik Dahlström (inactive), 2014-05-16 14:35:50]

The CQ bit was checked by ed@opera.com

[commit-bot: I haz the power, 2014-05-16 14:35:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ed@opera.com/261773008/100001

[commit-bot: I haz the power, 2014-05-16 15:15:42]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/6909)

[commit-bot: I haz the power, 2014-05-16 16:00:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 16:00:04]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/6918)

[Erik Dahlström (inactive), 2014-05-16 16:20:58]

The CQ bit was checked by ed@opera.com

[commit-bot: I haz the power, 2014-05-16 16:21:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ed@opera.com/261773008/100001

[commit-bot: I haz the power, 2014-05-16 17:06:28]

Change committed as 174186