Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 261773008: [SVG2] css 'outline' property should apply to svg elements (Closed)

Created:
6 years, 7 months ago by Erik Dahlström (inactive)
Modified:
6 years, 7 months ago
Reviewers:
pdr., f(malita), fs
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[SVG2] css 'outline' property should apply to svg elements The 'outline' property was only partially working in svg before this patch, this makes it work on text and text content child elements too. This makes SVG render the outlines as part of the foreground paint phase. Partly based on Florin Malita's webkit patch https://bugs.webkit.org/show_bug.cgi?id=113666#c12. BUG=369473 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174186

Patch Set 1 #

Patch Set 2 : simplify and fix overpainting bug #

Patch Set 3 : changes from webkit patch + rebase + more tests #

Patch Set 4 : fix failing tests + rebase #

Patch Set 5 : moar tests #

Total comments: 1

Patch Set 6 : use Ahem instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -68 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/focus-ring-text.svg View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/focus-ring-text-expected.html View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/outline-stacking.svg View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/outline-stacking-expected.svg View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/rgba-color-outline.svg View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/rgba-color-outline-expected.html View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/text-outline.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/text-outline-2.html View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/text-outline-2-expected.html View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/text-outline-expected.svg View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/text-outline-rgba.html View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/text-outline-rgba-expected.html View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/textpath-outline.svg View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/textpath-outline-expected.svg View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/tspan-multiple-outline.svg View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/tspan-multiple-outline-expected.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/tspan-outline.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/tspan-outline-2.svg View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/tspan-outline-2-expected.svg View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/tspan-outline-expected.svg View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGContainer.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.cpp View 1 2 2 chunks +21 lines, -20 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 1 2 1 chunk +43 lines, -44 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 1 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 1 2 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Erik Dahlström (inactive)
6 years, 7 months ago (2014-05-09 10:23:17 UTC) #1
krit
On 2014/05/09 10:23:17, Erik Dahlström wrote: I was skeptical about changing the way focus rings/outlines ...
6 years, 7 months ago (2014-05-09 16:31:10 UTC) #2
pdr.
I think this looks reasonable. I'm a little worried about diverging from the paintphases used ...
6 years, 7 months ago (2014-05-09 18:56:39 UTC) #3
f(malita)
lgtm
6 years, 7 months ago (2014-05-12 11:29:02 UTC) #4
krit
On 2014/05/12 11:29:02, Florin Malita wrote: > lgtm It seems that there are repaint issues ...
6 years, 7 months ago (2014-05-12 18:23:07 UTC) #5
Erik Dahlström (inactive)
On 2014/05/12 18:23:07, krit wrote: > On 2014/05/12 11:29:02, Florin Malita wrote: > > lgtm ...
6 years, 7 months ago (2014-05-16 12:19:21 UTC) #6
Erik Dahlström (inactive)
The CQ bit was checked by ed@opera.com
6 years, 7 months ago (2014-05-16 14:35:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/261773008/100001
6 years, 7 months ago (2014-05-16 14:35:58 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 15:15:42 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 16:00:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/6918)
6 years, 7 months ago (2014-05-16 16:00:04 UTC) #11
Erik Dahlström (inactive)
The CQ bit was checked by ed@opera.com
6 years, 7 months ago (2014-05-16 16:20:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/261773008/100001
6 years, 7 months ago (2014-05-16 16:21:07 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 17:06:28 UTC) #14
Message was sent while issue was closed.
Change committed as 174186

Powered by Google App Engine
This is Rietveld 408576698