Issue 261773006: Tighten up Object.observe code to ASSERT that it never deals with globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 261773006: Tighten up Object.observe code to ASSERT that it never deals with globals (Closed)

Created:
6 years, 7 months ago by adamk

Modified:
6 years, 7 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev, rossberg, dcarney, rafaelw

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Tighten up Object.observe code to ASSERT that it never deals with globals After r21126, Object.observe no longer allows observing the global proxy object. This patch replaces codepaths that used to handle that case with asserts showing that no such observation happens. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21151

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -15 lines)			Patch
	M	src/objects.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
	M	src/runtime.cc	View		2 chunks	+2 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adamk

6 years, 7 months ago (2014-05-05 21:44:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21151 (presubmit successful).

Expand Messages | Collapse Messages