Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

Issue 2617633004: Fix AccessibilityExtensionLoader's handling of locked screen (Closed)
Patch Set: Test removals. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
index fce4b86dec27e4f981629cc3975d906b8b94a07d..ea33e644ecda8a3c16f80242537795fed10d9626 100644
--- a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
+++ b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
@@ -74,21 +74,6 @@ bool ChromeWebViewGuestDelegate::HandleContextMenu(
return true;
}
-void ChromeWebViewGuestDelegate::OnDidInitialize() {
-#if defined(OS_CHROMEOS)
- if (chrome::IsRunningInMash()) {
- NOTIMPLEMENTED();
- return;
- }
- chromeos::AccessibilityManager* accessibility_manager =
- chromeos::AccessibilityManager::Get();
- CHECK(accessibility_manager);
- accessibility_subscription_ = accessibility_manager->RegisterCallback(
- base::Bind(&ChromeWebViewGuestDelegate::OnAccessibilityStatusChanged,
- weak_ptr_factory_.GetWeakPtr()));
-#endif
-}
-
// static
std::unique_ptr<base::ListValue> ChromeWebViewGuestDelegate::MenuModelToValue(
const ui::SimpleMenuModel& menu_model) {
@@ -128,35 +113,6 @@ bool ChromeWebViewGuestDelegate::ShouldHandleFindRequestsForEmbedder() const {
chrome::kChromeUIChromeSigninURL;
}
-void ChromeWebViewGuestDelegate::InjectChromeVoxIfNeeded(
- content::RenderViewHost* render_view_host) {
-#if defined(OS_CHROMEOS)
- if (!chromevox_injected_) {
- chromeos::AccessibilityManager* manager =
- chromeos::AccessibilityManager::Get();
- if (manager && manager->IsSpokenFeedbackEnabled()) {
- manager->InjectChromeVox(render_view_host);
- chromevox_injected_ = true;
- }
- }
-#endif
-}
-
-#if defined(OS_CHROMEOS)
-void ChromeWebViewGuestDelegate::OnAccessibilityStatusChanged(
- const chromeos::AccessibilityStatusEventDetails& details) {
- if (details.notification_type == chromeos::ACCESSIBILITY_MANAGER_SHUTDOWN) {
- accessibility_subscription_.reset();
- } else if (details.notification_type ==
- chromeos::ACCESSIBILITY_TOGGLE_SPOKEN_FEEDBACK) {
- if (details.enabled)
- InjectChromeVoxIfNeeded(guest_web_contents()->GetRenderViewHost());
- else
- chromevox_injected_ = false;
- }
-}
-#endif
-
void ChromeWebViewGuestDelegate::SetContextMenuPosition(
const gfx::Point& position) {
if (context_menu_position_ == nullptr)

Powered by Google App Engine
This is Rietveld 408576698