Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h

Issue 2617583006: Using native sheet to display modal dialogs for sign in (Closed)
Patch Set: Little fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
diff --git a/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h b/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
index d0dd30235fdf77c5ba21c658a55db62ed7cfa83f..0bd808d79b7c0ab05474bb4c898262f167d89419 100644
--- a/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
+++ b/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
@@ -9,12 +9,10 @@
#include "base/mac/scoped_nsobject.h"
#include "base/macros.h"
-#include "chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h"
#include "chrome/browser/ui/profile_chooser_constants.h"
#include "chrome/browser/ui/signin_view_controller_delegate.h"
@class ConstrainedWindowCustomWindow;
-class ConstrainedWindowMac;
class Profile;
namespace content {
@@ -30,8 +28,7 @@ enum class AccessPoint;
// managing the Signin and Sync Confirmation tab-modal dialogs.
// Instances of this class delete themselves when the window they manage is
// closed (in the OnConstrainedWindowClosed callback).
-class SigninViewControllerDelegateMac : public ConstrainedWindowMacDelegate,
- public SigninViewControllerDelegate {
+class SigninViewControllerDelegateMac : public SigninViewControllerDelegate {
public:
// Creates and displays a constrained window off of |host_web_contents|,
// containing |web_contents|. If |wait_for_size| is true, the delegate will
@@ -45,8 +42,6 @@ class SigninViewControllerDelegateMac : public ConstrainedWindowMacDelegate,
NSRect frame,
bool wait_for_size);
- void OnConstrainedWindowClosed(ConstrainedWindowMac* window) override;
-
// Creates the web view that contains the signin flow in |mode| using
// |profile| as the web content's profile, then sets |delegate| as the created
// web content's delegate.
@@ -74,10 +69,6 @@ class SigninViewControllerDelegateMac : public ConstrainedWindowMacDelegate,
~SigninViewControllerDelegateMac() override;
- // The constrained window opened by this delegate to display signin flow
- // content.
- std::unique_ptr<ConstrainedWindowMac> constrained_window_;
-
// The web contents displayed in the constrained window.
std::unique_ptr<content::WebContents> web_contents_;
base::scoped_nsobject<ConstrainedWindowCustomWindow> window_;

Powered by Google App Engine
This is Rietveld 408576698