Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3526)

Unified Diff: chrome/browser/ui/signin_view_controller_delegate.h

Issue 2617583006: Using native sheet to display modal dialogs for sign in (Closed)
Patch Set: Private SigninViewControllerDelegateMac constructor Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/signin_view_controller_delegate.h
diff --git a/chrome/browser/ui/signin_view_controller_delegate.h b/chrome/browser/ui/signin_view_controller_delegate.h
index 6f9de730afaa68b05ed917bc8a88e0dbd49901a1..021070d78675515542a4bb4f7d4cbc6a87a5403e 100644
--- a/chrome/browser/ui/signin_view_controller_delegate.h
+++ b/chrome/browser/ui/signin_view_controller_delegate.h
@@ -46,10 +46,14 @@ class SigninViewControllerDelegate : public content::WebContentsDelegate {
SigninViewController* signin_view_controller,
Browser* browser);
+ // Closes the sign-in dialog. Note that this method may destroy this object,
+ // so the caller should no longer use this object after calling this method.
void CloseModalSignin();
// Either navigates back in the signin flow if the history state allows it or
- // closes the flow otherwise.
+ // closes the flow otherwise. Note that if view is closed, this method may
+ // destroy this object, so the caller should no longer use this object after
+ // calling this method.
void PerformNavigation();
// This will be called by the base class to request a resize of the native
@@ -78,7 +82,9 @@ class SigninViewControllerDelegate : public content::WebContentsDelegate {
// This will be called by this base class when the tab-modal window must be
// closed. This should close the platform-specific window that is currently
- // showing the sign in flow or the sync confirmation dialog.
+ // showing the sign in flow or the sync confirmation dialog. Note that this
+ // method may destroy this object, so the caller should no longer use this
+ // object after calling this method.
virtual void PerformClose() = 0;
private:

Powered by Google App Engine
This is Rietveld 408576698