Using native sheet to display modal dialogs for sign in

chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h

Index: chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
diff --git a/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h b/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
index d0dd30235fdf77c5ba21c658a55db62ed7cfa83f..a866e953850cbddc8dc4bca37a9c02bc93744805 100644
--- a/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
+++ b/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
@@ -12,6 +12,7 @@
 #include "chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h"
 #include "chrome/browser/ui/profile_chooser_constants.h"
 #include "chrome/browser/ui/signin_view_controller_delegate.h"
+#include "ui/base/ui_base_types.h"
 
 @class ConstrainedWindowCustomWindow;
 class ConstrainedWindowMac;
@@ -43,6 +44,7 @@ class SigninViewControllerDelegateMac : public ConstrainedWindowMacDelegate,
       std::unique_ptr<content::WebContents> web_contents,
       content::WebContents* host_web_contents,
       NSRect frame,
+      ui::ModalType dialog_modal_type,

[msarda, 2017/01/11 14:29:21]

For consistency with the views implementation, please make the constructor a
private method and make SigninViewControllerDelegate a friend - see
https://codereview.chromium.org/2619963003/diff/40001/chrome/browser/ui/views...

[jlebel, 2017/01/11 14:39:52]

Done.

       bool wait_for_size);
 
   void OnConstrainedWindowClosed(ConstrainedWindowMac* window) override;
@@ -74,6 +76,9 @@ class SigninViewControllerDelegateMac : public ConstrainedWindowMacDelegate,
 
   ~SigninViewControllerDelegateMac() override;
 
+  // Deletes this object.
+  void DeleteThis();
+
   // The constrained window opened by this delegate to display signin flow
   // content.
   std::unique_ptr<ConstrainedWindowMac> constrained_window_;
@@ -90,6 +95,10 @@ class SigninViewControllerDelegateMac : public ConstrainedWindowMacDelegate,
   // The web contents that the constrained window is displayed off of.
   // Typically, this is going to be the active tab when the window is shown.
   content::WebContents* host_web_contents_;
+
+  // The dialog modal presentation type.
+  ui::ModalType dialog_modal_type_;
+
   NSRect window_frame_;
 
   DISALLOW_COPY_AND_ASSIGN(SigninViewControllerDelegateMac);