Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h

Issue 2617583006: Using native sheet to display modal dialogs for sign in (Closed)
Patch Set: Tab/Window modal parameter Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
diff --git a/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h b/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
index d0dd30235fdf77c5ba21c658a55db62ed7cfa83f..b339acd4e88fa3c0a57180a069db7287aaa17c5e 100644
--- a/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
+++ b/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
@@ -43,6 +43,7 @@ class SigninViewControllerDelegateMac : public ConstrainedWindowMacDelegate,
std::unique_ptr<content::WebContents> web_contents,
content::WebContents* host_web_contents,
NSRect frame,
+ DialogModalType dialog_modal_type,
bool wait_for_size);
void OnConstrainedWindowClosed(ConstrainedWindowMac* window) override;
@@ -74,6 +75,9 @@ class SigninViewControllerDelegateMac : public ConstrainedWindowMacDelegate,
~SigninViewControllerDelegateMac() override;
+ // Called to delete |this|.
+ void DeleteThis();
+
// The constrained window opened by this delegate to display signin flow
// content.
std::unique_ptr<ConstrainedWindowMac> constrained_window_;
@@ -90,6 +94,10 @@ class SigninViewControllerDelegateMac : public ConstrainedWindowMacDelegate,
// The web contents that the constrained window is displayed off of.
// Typically, this is going to be the active tab when the window is shown.
content::WebContents* host_web_contents_;
+
+ // The dialog modal presentation type.
+ DialogModalType dialog_modal_type_;
+
NSRect window_frame_;
DISALLOW_COPY_AND_ASSIGN(SigninViewControllerDelegateMac);

Powered by Google App Engine
This is Rietveld 408576698