Using native sheet to display modal dialogs for sign in

chrome/browser/ui/signin_view_controller_delegate.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_SIGNIN_VIEW_CONTROLLER_DELEGATE_H_
 #define CHROME_BROWSER_UI_SIGNIN_VIEW_CONTROLLER_DELEGATE_H_
 
 #include "chrome/browser/ui/profile_chooser_constants.h"
 #include "content/public/browser/web_contents_delegate.h"
 
@@ skipping 28 matching lines @@
       SigninViewController* signin_view_controller,
       Browser* browser);
 
   // Returns a platform-specific SigninViewControllerDelegate instance that
   // displays the modal sign in error dialog. The returned object should delete
   // itself when the window it's managing is closed.
   static SigninViewControllerDelegate* CreateSigninErrorDelegate(
       SigninViewController* signin_view_controller,
       Browser* browser);
 
+  // Closes the Sign in dialog. The instance should be considered has being
+  // destroyed.
   void CloseModalSignin();

[msarda, 2017/01/10 15:58:43]

There is a typo in this comment: "the instance should be considered has being
destroyed."

I would change this comment and the ones below as the following:
"Closes the sign-in dialog. Note that this method may destroy this object,
so the caller should no longer use this object after calling this method."

[jlebel, 2017/01/11 14:25:24]

Done.

 
   // Either navigates back in the signin flow if the history state allows it or
-  // closes the flow otherwise.
+  // closes the flow otherwise. If view is closed, the instance should be
+  // considered has being destroyed.
   void PerformNavigation();
 
   // This will be called by the base class to request a resize of the native
   // view hosting the content to |height|. |height| is the total height of the
   // content, in pixels.
   virtual void ResizeNativeView(int height) = 0;
 
   // content::WebContentsDelegate:
   bool HandleContextMenu(const content::ContextMenuParams& params) override;
 
   // WebContents is used for executing javascript in the context of a modal sync
   // confirmation dialog.
   content::WebContents* web_contents_for_testing() { return web_contents_; }
 
  protected:
+  // The presentation type of the modal sign-in dialog.
+  enum DialogModalType {
+    // The sign-in dialog is presented as tab modal: the user may interact with
+    // the parent window and the dialog is dismissed on tab navigation.
+    TAB_MODAL,
+
+    // The sign-in dialog is presented as window modal: the user cannot interact
+    // with the parent window an
+    WINDOW_MODAL
+  };
+
   SigninViewControllerDelegate(SigninViewController* signin_view_controller,
                                content::WebContents* web_contents);
   ~SigninViewControllerDelegate() override;
 
   // Notifies the SigninViewController that this instance is being deleted.
   void ResetSigninViewControllerDelegate();
 
   // content::WebContentsDelegate
   void LoadingStateChanged(content::WebContents* source,
                            bool to_different_document) override;
 
   // This will be called by this base class when the tab-modal window must be
   // closed. This should close the platform-specific window that is currently
-  // showing the sign in flow or the sync confirmation dialog.
+  // showing the sign in flow or the sync confirmation dialog. After this call,
+  // the current instance should be considered has being destroyed.
   virtual void PerformClose() = 0;
 
  private:
   bool CanGoBack(content::WebContents* web_ui_web_contents) const;
 
   SigninViewController* signin_view_controller_;  // Not owned.
   content::WebContents* web_contents_;  // Not owned.
   DISALLOW_COPY_AND_ASSIGN(SigninViewControllerDelegate);
 };
 
 #endif  // CHROME_BROWSER_UI_SIGNIN_VIEW_CONTROLLER_DELEGATE_H_