Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2617583005: Remove ContextClient from NavigatorStorageQuota

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextClient from NavigatorStorageQuota Now that Navigator's supplement can get a Navigator object via host(). Then Navigator's supplement doesn't need to observe ContextClient. BUG=610176

Patch Set 1 #

Total comments: 2

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.h View 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp View 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 31 (17 generated)
haraken
PTAL https://codereview.chromium.org/2617583005/diff/1/third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp File third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp (left): https://codereview.chromium.org/2617583005/diff/1/third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp#oldcode76 third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp:76: if (!m_storageQuota && frame()) These frame() checks won't ...
3 years, 11 months ago (2017-01-06 01:20:37 UTC) #2
sof
lgtm https://codereview.chromium.org/2617583005/diff/1/third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp File third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp (left): https://codereview.chromium.org/2617583005/diff/1/third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp#oldcode76 third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp:76: if (!m_storageQuota && frame()) On 2017/01/06 01:20:37, haraken ...
3 years, 11 months ago (2017-01-06 07:22:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617583005/1
3 years, 11 months ago (2017-01-06 07:26:37 UTC) #9
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago (2017-01-06 07:35:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617583005/1
3 years, 11 months ago (2017-01-06 07:55:16 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/336272)
3 years, 11 months ago (2017-01-06 08:02:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617583005/1
3 years, 11 months ago (2017-01-06 08:05:42 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/336283)
3 years, 11 months ago (2017-01-06 08:11:18 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617583005/20001
3 years, 11 months ago (2017-01-06 08:15:17 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/336286)
3 years, 11 months ago (2017-01-06 08:21:17 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617583005/20001
3 years, 11 months ago (2017-01-11 08:32:18 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/339346)
3 years, 11 months ago (2017-01-11 08:38:21 UTC) #29
haraken
On 2017/01/11 08:38:21, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 11 months ago (2017-01-11 09:03:12 UTC) #30
haraken
3 years, 11 months ago (2017-01-11 09:06:20 UTC) #31
On 2017/01/11 09:03:12, haraken wrote:
> On 2017/01/11 08:38:21, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> I don't know why this hits an error on chromium_presubmit.
> 
> Let me create a new issue and land.

Ah, I noticed that this has been landed in
https://chromium.googlesource.com/chromium/src/+/afe1dc47d88d3410018a27c812d8...
but this issue was not updated for some reason.

Powered by Google App Engine
This is Rietveld 408576698