|
|
DescriptionRemove ContextClient from NavigatorStorageQuota
Now that Navigator's supplement can get a Navigator object via host().
Then Navigator's supplement doesn't need to observe ContextClient.
BUG=610176
Patch Set 1 #
Total comments: 2
Patch Set 2 : temp #
Messages
Total messages: 31 (17 generated)
haraken@chromium.org changed reviewers: + sigbjornf@opera.com
PTAL https://codereview.chromium.org/2617583005/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp (left): https://codereview.chromium.org/2617583005/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp:76: if (!m_storageQuota && frame()) These frame() checks won't really make sense, so dropped.
The CQ bit was checked by haraken@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2617583005/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp (left): https://codereview.chromium.org/2617583005/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp:76: if (!m_storageQuota && frame()) On 2017/01/06 01:20:37, haraken wrote: > > These frame() checks won't really make sense, so dropped. Looks fine. Digging around in history, it seems like one of the earliest of these conditional-creation methods used to access frame() upon lazily creating to emit a console message..which was subsequently dropped. But the consistency of checking frame() before creating remained & used when extending this interface.
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1483687592440430, "parent_rev": "ff41261e9ecf43ae2f61a10177cca9afe585607b", "commit_rev": "afe1dc47d88d3410018a27c812d8bbd6e3d1d859"}
The CQ bit was unchecked by commit-bot@chromium.org
Prior attempt to commit was detected, but we were not able to check whether the issue was successfully committed. Please check Git history manually and re-check CQ or close this issue as needed.
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by haraken@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com Link to the patchset: https://codereview.chromium.org/2617583005/#ps20001 (title: "temp")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2017/01/11 08:38:21, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) I don't know why this hits an error on chromium_presubmit. Let me create a new issue and land.
On 2017/01/11 09:03:12, haraken wrote: > On 2017/01/11 08:38:21, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) > > I don't know why this hits an error on chromium_presubmit. > > Let me create a new issue and land. Ah, I noticed that this has been landed in https://chromium.googlesource.com/chromium/src/+/afe1dc47d88d3410018a27c812d8... but this issue was not updated for some reason. |