Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2617553002: DevTools: Split Timeline started UMA metric into two parts. (Closed)
Patch Set: update the test. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 535 matching lines...) Expand 10 before | Expand all | Expand 10 after
546 provider => Timeline.TimelinePanel._settingForTraceProvider(provider).ge t()); 546 provider => Timeline.TimelinePanel._settingForTraceProvider(provider).ge t());
547 547
548 const recordingOptions = this._landingPage.recordingOptions(); 548 const recordingOptions = this._landingPage.recordingOptions();
549 this._controller = new Timeline.TimelineController(mainTarget, this, this._t racingModel); 549 this._controller = new Timeline.TimelineController(mainTarget, this, this._t racingModel);
550 this._controller.startRecording(recordingOptions, enabledTraceProviders); 550 this._controller.startRecording(recordingOptions, enabledTraceProviders);
551 this._recordingStartTime = Date.now(); 551 this._recordingStartTime = Date.now();
552 552
553 for (var i = 0; i < this._overviewControls.length; ++i) 553 for (var i = 0; i < this._overviewControls.length; ++i)
554 this._overviewControls[i].timelineStarted(); 554 this._overviewControls[i].timelineStarted();
555 555
556 Host.userMetrics.actionTaken(Host.UserMetrics.Action.TimelineStarted); 556 Host.userMetrics.actionTaken(userInitiated ? Host.UserMetrics.Action.Timelin eStarted : Host.UserMetrics.Action.TimelinePageReloadStarted);
557 this._setUIControlsEnabled(false); 557 this._setUIControlsEnabled(false);
558 this._hideLandingPage(); 558 this._hideLandingPage();
559 } 559 }
560 560
561 _stopRecording() { 561 _stopRecording() {
562 if (this._statusPane) { 562 if (this._statusPane) {
563 this._statusPane.finish(); 563 this._statusPane.finish();
564 this._statusPane.updateStatus(Common.UIString('Stopping timeline\u2026')); 564 this._statusPane.updateStatus(Common.UIString('Stopping timeline\u2026'));
565 this._statusPane.updateProgressBar(Common.UIString('Received'), 0); 565 this._statusPane.updateProgressBar(Common.UIString('Received'), 0);
566 } 566 }
(...skipping 1353 matching lines...) Expand 10 before | Expand all | Expand 10 after
1920 } 1920 }
1921 1921
1922 /** 1922 /**
1923 * @override 1923 * @override
1924 * @param {!SDK.Target} target 1924 * @param {!SDK.Target} target
1925 */ 1925 */
1926 targetRemoved(target) { 1926 targetRemoved(target) {
1927 this._targets.remove(target, true); 1927 this._targets.remove(target, true);
1928 } 1928 }
1929 }; 1929 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/host/UserMetrics.js ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698