chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc - Issue 2617543002: Create Desktop to iOS Promotion skeleton.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

Issue 2617543002: Create Desktop to iOS Promotion skeleton. (Closed)

Patch Set: add cocoa modifications Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('k') | chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

index 9acf39184ed90bc0fb35a6265dfaf9abe830dfe9..626d399d04d714be22e1290105364e6d6f7e7fa9 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

@@ -341,7 +341,7 @@ TEST_F(ManagePasswordsBubbleModelTest, SuppressSignInPromo) {

EXPECT_CALL(*controller(), SavePassword());

model()->OnSaveClicked();

- EXPECT_FALSE(model()->ReplaceToShowSignInPromoIfNeeded());

+ EXPECT_FALSE(model()->ReplaceToShowPromotionIfNeeded());

DestroyModel();

histogram_tester.ExpectTotalCount(kSignInPromoDismissalReasonMetric, 0);

histogram_tester.ExpectTotalCount(kSignInPromoCountTilSignInMetric, 0);

@@ -361,7 +361,7 @@ TEST_F(ManagePasswordsBubbleModelTest, SignInPromoOK) {

EXPECT_CALL(*controller(), SavePassword());

model()->OnSaveClicked();

- EXPECT_TRUE(model()->ReplaceToShowSignInPromoIfNeeded());

+ EXPECT_TRUE(model()->ReplaceToShowPromotionIfNeeded());

EXPECT_CALL(*controller(), NavigateToChromeSignIn());

model()->OnSignInToChromeClicked();

DestroyModel();

@@ -390,7 +390,7 @@ TEST_F(ManagePasswordsBubbleModelTest, SignInPromoCancel) {

EXPECT_CALL(*controller(), SavePassword());

model()->OnSaveClicked();

- EXPECT_TRUE(model()->ReplaceToShowSignInPromoIfNeeded());

+ EXPECT_TRUE(model()->ReplaceToShowPromotionIfNeeded());

model()->OnSkipSignInClicked();

DestroyModel();

histogram_tester.ExpectUniqueSample(

@@ -418,7 +418,7 @@ TEST_F(ManagePasswordsBubbleModelTest, SignInPromoDismiss) {

EXPECT_CALL(*controller(), SavePassword());

model()->OnSaveClicked();

- EXPECT_TRUE(model()->ReplaceToShowSignInPromoIfNeeded());

+ EXPECT_TRUE(model()->ReplaceToShowPromotionIfNeeded());

DestroyModel();

histogram_tester.ExpectUniqueSample(

kUIDismissalReasonMetric,