Create Desktop to iOS Promotion skeleton.

chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_model.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_DESKTOP_IOS_PROMOTION_DESKTOP_IOS_PROMOTION_MODEL_H_
+#define CHROME_BROWSER_UI_DESKTOP_IOS_PROMOTION_DESKTOP_IOS_PROMOTION_MODEL_H_
+
+#include <memory>

[sky, 2017/01/04 20:52:36]

AFAICT you don't use this include.

[mrefaat, 2017/01/05 00:04:09]

Done.

+
+#include "base/macros.h"
+#include "chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util.h"

[sky, 2017/01/04 20:52:36]

Generally we forward declare when possible (it's in chromium style guide). I
think you have this include because of PromotionEntryPoint. You should be able
to forward declare it.

[mrefaat, 2017/01/05 00:04:09]

Done.

+
+// This model provides data to the Desktop to mobile promotion and control the
+// promotion actions.
+class DesktopIOSPromotionModel {

[sky, 2017/01/04 20:52:37]

How come you are naming this class as the model? This class doesn't seem like a
model from what I can tell.

[mrefaat, 2017/01/05 00:03:08]

i thought first i'd name it Controller - but after looking through the code for
password manager i found that it's the model that controls the actions of the
password bubble. vasilii@ what do you think ?

[vasilii, 2017/01/05 17:40:20]

For the password manager there are two classes: ManagePasswordsBubbleModel
(contains as much platform independent code for the bubble as possible) and
ManagePasswordsUIController. The latter does the real stuff.

[mrefaat, 2017/01/05 23:54:42]

i changed it to be controller instead

+ public:
+  // Should be instantiated on the UI thread.
+  explicit DesktopIOSPromotionModel(
+      desktop_ios_promotion::PromotionEntryPoint entry_point);
+

[sky, 2017/01/04 20:52:37]

Don't inline the destructor.

[mrefaat, 2017/01/05 00:03:08]

Done.

+  // Called by the view code when "Send SMS" button is clicked by the user.
+  void OnSendSMSClicked();
+
+  // Called by the view code when "No Thanks" button is clicked by the user.
+  void OnNoThanksClicked();
+
+ private:
+

[sky, 2017/01/04 20:52:36]

remove newline.

[mrefaat, 2017/01/05 00:03:08]

Done.

+   desktop_ios_promotion::PromotionEntryPoint entry_point_;

[sky, 2017/01/04 20:52:36]

const

[mrefaat, 2017/01/05 00:03:08]

Done.

+
+  // (TODO): If needed verify that functions that affect the UI are done
+  // on the same thread.
+
+  DISALLOW_COPY_AND_ASSIGN(DesktopIOSPromotionModel);
+};
+
+#endif  // CHROME_BROWSER_UI_DESKTOP_IOS_PROMOTION_DESKTOP_IOS_PROMOTION_MODEL_H_