Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2617533003: MD Settings: change most checkboxes to toggles (leave dialogs alone) (Closed)
Patch Set: fix tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/people_page.html
diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html
index d9b0d40947765e1e40dd95344c5e139249ff7e31..105745a435b8007df1604fcd99eb552e999db98b 100644
--- a/chrome/browser/resources/settings/people_page/people_page.html
+++ b/chrome/browser/resources/settings/people_page/people_page.html
@@ -10,7 +10,7 @@
<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-checkbox.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
-<link rel="import" href="/controls/settings_checkbox.html">
+<link rel="import" href="/controls/settings_toggle_button.html">
<link rel="import" href="/people_page/sync_page.html">
<link rel="import" href="/people_page/profile_info_browser_proxy.html">
<link rel="import" href="/people_page/sync_browser_proxy.html">
@@ -200,10 +200,11 @@
<if expr="chromeos">
<template is="dom-if" if="[[!quickUnlockEnabled_]]">
- <div class="settings-box single-column">
- <settings-checkbox pref="{{prefs.settings.enable_screen_lock}}"
+ <div class="settings-box">
+ <settings-toggle-button class="start"
+ pref="{{prefs.settings.enable_screen_lock}}"
label="$i18n{enableScreenlock}">
- </settings-checkbox>
+ </settings-toggle-button>
</div>
</template>
@@ -235,13 +236,15 @@
<a target="_blank" href="$i18n{easyUnlockLearnMoreURL}">
$i18n{learnMore}
</a>
+ <!-- TODO(dbeam): this should be 1 dom-if with a method instead
+ of 2 nested dom-ifs. -->
<template is="dom-if" if="[[easyUnlockEnabled_]]">
<template is="dom-if"
if="[[easyUnlockProximityDetectionAllowed_]]">
- <settings-checkbox
+ <settings-toggle-button
pref="{{prefs.easy_unlock.proximity_required}}"
label="$i18n{easyUnlockRequireProximityLabel}">
- </settings-checkbox>
+ </settings-toggle-button>
</template>
</template>
</div>

Powered by Google App Engine
This is Rietveld 408576698