chrome/browser/resources/settings/downloads_page/downloads_page.html - Issue 2617533003: MD Settings: change most checkboxes to toggles (leave dialogs alone)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/downloads_page/downloads_page.html

Issue 2617533003: MD Settings: change most checkboxes to toggles (leave dialogs alone) (Closed)

Patch Set: fix tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/device_page/stylus.html ('k') | chrome/browser/resources/settings/internet_page/internet_detail_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/downloads_page/downloads_page.html

diff --git a/chrome/browser/resources/settings/downloads_page/downloads_page.html b/chrome/browser/resources/settings/downloads_page/downloads_page.html

index ee334ebcd05895bc5ba336f26d4d304c4776740f..6c70bac987598a61e732537300c20e5e228300cb 100644

--- a/chrome/browser/resources/settings/downloads_page/downloads_page.html

+++ b/chrome/browser/resources/settings/downloads_page/downloads_page.html

@@ -1,7 +1,7 @@

-<link rel="import" href="/controls/settings_checkbox.html">

+<link rel="import" href="/controls/settings_toggle_button.html">

<dom-module id="settings-downloads-page">

@@ -29,14 +29,16 @@

</div>

- <settings-checkbox pref="{{prefs.download.prompt_for_download}}"

+ <settings-toggle-button

+ pref="{{prefs.download.prompt_for_download}}"

label="$i18n{promptForDownload}">

- </settings-checkbox>

+ </settings-toggle-button>

- <settings-checkbox pref="{{prefs.gdata.disabled}}"

+ <settings-toggle-button

+ pref="{{prefs.gdata.disabled}}"

label="$i18n{disconnectGoogleDriveAccount}"

hidden="[[!pageVisibility.googleDrive]]">

- </settings-checkbox>

+ </settings-toggle-button>

</if>

</div>

</template>