Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 261753019: Revert of Mark forwarded user gestures as forwarded, and don't forward already forwarded gestures. (Closed)

Created:
6 years, 7 months ago by Marijn Kruisselbrink
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Revert of Mark forwarded user gestures as forwarded, and don't forward already forwarded user gestures. (https://codereview.chromium.org/256623008/) Reason for revert: The blink-side change for this had the unintended side effect of breaking websites, so reverting this while we figure out a proper fix. BUG=369963 Original issue's description: > Mark forwarded user gestures as forwarded, and don't forward already forwarded user gestures. > > BUG=354217 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267057 TBR=kalman@chromium.org NOTRY=true BUG=354217 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268635

Patch Set 1 #

Patch Set 2 : rebase, this code moved around... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -43 lines) Patch
M chrome/browser/extensions/extension_messages_apitest.cc View 1 1 chunk +0 lines, -32 lines 0 comments Download
M extensions/renderer/messaging_bindings.cc View 1 4 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Marijn Kruisselbrink
Created Revert of Mark forwarded user gestures as forwarded, and don't forward already forwarded user ...
6 years, 7 months ago (2014-05-06 17:49:10 UTC) #1
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org
6 years, 7 months ago (2014-05-06 17:50:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/261753019/1
6 years, 7 months ago (2014-05-06 17:51:13 UTC) #3
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org
6 years, 7 months ago (2014-05-06 17:55:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/261753019/60001
6 years, 7 months ago (2014-05-06 17:57:02 UTC) #5
Marijn Kruisselbrink
The CQ bit was unchecked by mek@chromium.org
6 years, 7 months ago (2014-05-06 23:19:01 UTC) #6
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org
6 years, 7 months ago (2014-05-06 23:19:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/261753019/60001
6 years, 7 months ago (2014-05-06 23:19:59 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 23:23:16 UTC) #9
Message was sent while issue was closed.
Change committed as 268635

Powered by Google App Engine
This is Rietveld 408576698