Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 261753015: SimpleMessageBoxViews: UI message loop does not need to be running on Linux. (Closed)

Created:
6 years, 7 months ago by mattm
Modified:
6 years, 7 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews, tfarina, msw
Visibility:
Public.

Description

SimpleMessageBoxViews: UI message loop does not need to be running on Linux. Fixes ProcessSingletonDialogLinux not showing a dialog. BUG=367048 TEST=run "mkdir /tmp/locktest && ln -s fakehost-1234 /tmp/locktest/SingletonLock && chrome --user-data-dir=/tmp/locktest". A dialog should appear allowing you to quit or unlock the profile. If you click quit, /tmp/locktest/SingletonLock file should remain untouched. If you click unlock, chrome should launch normally. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268793

Patch Set 1 #

Patch Set 2 : test if ResourceBundle is initialized #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/ui/views/simple_message_box_views.cc View 1 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mattm
sky: for review erg: just in case you have any comments/opinions msw: fyi
6 years, 7 months ago (2014-05-06 02:56:56 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-06 15:37:18 UTC) #2
Elliot Glaysher
lgtm
6 years, 7 months ago (2014-05-06 18:17:40 UTC) #3
Elliot Glaysher
On 2014/05/06 18:17:40, Elliot Glaysher wrote: > lgtm Actually, could you also please put a ...
6 years, 7 months ago (2014-05-06 18:19:53 UTC) #4
mattm
Updated with test for ResourceBundle initialization, if you want to take another look. On 2014/05/06 ...
6 years, 7 months ago (2014-05-06 22:06:00 UTC) #5
sky
SLGTM
6 years, 7 months ago (2014-05-06 22:30:46 UTC) #6
mattm
The CQ bit was checked by mattm@chromium.org
6 years, 7 months ago (2014-05-06 22:42:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/261753015/20001
6 years, 7 months ago (2014-05-06 22:46:55 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 15:59:04 UTC) #9
Message was sent while issue was closed.
Change committed as 268793

Powered by Google App Engine
This is Rietveld 408576698