Implement VP9/I444 encode support in the Chromoting host.

Implement VP9/I444 encode support in the Chromoting host.

This will be selectable by clients that want to avoid I420 artefacts.

BUG=260879, 134202
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269774

[Wez, 2014-05-02 23:06:03]

PTAL

[Sergey Ulanov, 2014-05-04 19:09:16]

lgtm

https://codereview.chromium.org/261753013/diff/1/remoting/codec/video_encoder...
File remoting/codec/video_encoder_vpx.cc (right):

https://codereview.chromium.org/261753013/diff/1/remoting/codec/video_encoder...
remoting/codec/video_encoder_vpx.cc:378: 
nit: remove this line

https://codereview.chromium.org/261753013/diff/1/remoting/codec/video_encoder...
remoting/codec/video_encoder_vpx.cc:379: case VPX_IMG_FMT_I444:
nit: indent 2 spaces

https://codereview.chromium.org/261753013/diff/1/remoting/codec/video_encoder...
remoting/codec/video_encoder_vpx.cc:400: int y_offset = (y_stride * rect.top())
+ rect.left();
nit: remove extra parentheses or add them on the following line for consistency.

[Wez, 2014-05-09 14:47:33]

https://codereview.chromium.org/261753013/diff/1/remoting/codec/video_encoder...
File remoting/codec/video_encoder_vpx.cc (right):

https://codereview.chromium.org/261753013/diff/1/remoting/codec/video_encoder...
remoting/codec/video_encoder_vpx.cc:378: 
On 2014/05/04 19:09:17, Sergey Ulanov wrote:
> nit: remove this line

Done.

https://codereview.chromium.org/261753013/diff/1/remoting/codec/video_encoder...
remoting/codec/video_encoder_vpx.cc:379: case VPX_IMG_FMT_I444:
On 2014/05/04 19:09:17, Sergey Ulanov wrote:
> nit: indent 2 spaces

Done.

https://codereview.chromium.org/261753013/diff/1/remoting/codec/video_encoder...
remoting/codec/video_encoder_vpx.cc:400: int y_offset = (y_stride * rect.top())
+ rect.left();
On 2014/05/04 19:09:17, Sergey Ulanov wrote:
> nit: remove extra parentheses or add them on the following line for
consistency.

Done.

[Wez, 2014-05-09 14:47:38]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2014-05-09 14:49:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wez@chromium.org/261753013/20001

[commit-bot: I haz the power, 2014-05-09 16:57:45]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-09 17:09:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 17:09:18]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[Wez, 2014-05-12 11:55:48]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2014-05-12 11:56:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wez@chromium.org/261753013/40001

[commit-bot: I haz the power, 2014-05-12 13:19:18]

Change committed as 269774