Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: runtime/vm/object_graph.h

Issue 261753012: Make ObjectGraph a StackResource. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object_graph.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_graph.h
===================================================================
--- runtime/vm/object_graph.h (revision 35711)
+++ runtime/vm/object_graph.h (working copy)
@@ -5,6 +5,7 @@
#ifndef VM_OBJECT_GRAPH_H_
#define VM_OBJECT_GRAPH_H_
+#include "vm/allocation.h"
#include "vm/object.h"
namespace dart {
@@ -15,7 +16,7 @@
// Example uses:
// - find a retaining path from the isolate roots to a particular object, or
// - determine how much memory is retained by some particular object(s).
-class ObjectGraph {
+class ObjectGraph : public StackResource {
public:
class Stack;
@@ -45,11 +46,11 @@
};
virtual ~Visitor() { }
// Visits the object pointed to by *it. The iterator is only valid
- // during this call. This method must not allocate from the heap.
+ // during this call. This method must not allocate from the heap or
+ // trigger GC in any way.
virtual Direction VisitObject(StackIterator* it) = 0;
};
- // No GC is allowed during the lifetime of an ObjectGraph instance.
explicit ObjectGraph(Isolate* isolate);
~ObjectGraph();
« no previous file with comments | « no previous file | runtime/vm/object_graph.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698