Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 261753011: Revert of Make CSSFontFace::willUseFontData() load fonts with unicode-range (Closed)

Created:
6 years, 7 months ago by enne (OOO)
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, krit, jbroman, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, ojan, dglazkov+blink, Rik, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, danakj, pdr., rune+blink, Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Revert of Make CSSFontFace::willUseFontData() load fonts with unicode-range (https://codereview.chromium.org/248473005/) Reason for revert: Causes off-by-one text errors, e.g. SHOP->RGNO BUG=369633 Original issue's description: > Make CSSFontFace::willUseFontData() load fonts with unicode-range > > Before this patch CSSFontFace::willUseFontData() loads font faces that > have no unicode-range. Since font faces with no unicode-range tends to > be used as fallback font of segmented font family, this behavior leads > to unnecessary font downloads. > > This patch makes willUseFontData() loads the first unloaded font face > whose unicode-range intersects with given text. That check does not > need to be 100% precise (false negative is ok), so it only checks the > first character of the text, for speed. > > TEST=fast/css/font-face-unicode-range-overlap-load.html > BUG=247920, 246492 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172943 TBR=dglazkov@chromium.org,eae@chromium.org,ksakamoto@chromium.org NOTREECHECKS=true NOTRY=true BUG=247920, 246492 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -57 lines) Patch
M LayoutTests/fast/css/font-face-unicode-range-overlap-load.html View 3 chunks +1 line, -14 lines 0 comments Download
M LayoutTests/fast/css/font-face-unicode-range-overlap-load-expected.txt View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/css/CSSFontFace.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/css/CSSFontFace.cpp View 3 chunks +11 lines, -15 lines 0 comments Download
M Source/core/css/CSSFontSelector.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontSelector.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSSegmentedFontFace.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSegmentedFontFace.cpp View 1 chunk +4 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/platform/fonts/Font.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/Font.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/FontSelector.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
enne (OOO)
Created Revert of Make CSSFontFace::willUseFontData() load fonts with unicode-range
6 years, 7 months ago (2014-05-02 21:42:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/261753011/1
6 years, 7 months ago (2014-05-02 21:42:29 UTC) #2
commit-bot: I haz the power
Change committed as 173234
6 years, 7 months ago (2014-05-02 21:43:34 UTC) #3
eae
6 years, 7 months ago (2014-05-02 21:44:06 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698