Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: content/browser/service_worker/service_worker_internals_ui.cc

Issue 261753008: Call EmbeddedWorkerDevToolsManager::ServiceWorkerCreated, WorkerContextStarted and WorkerDestroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pass scope in StartWorker() Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_internals_ui.cc
diff --git a/content/browser/service_worker/service_worker_internals_ui.cc b/content/browser/service_worker/service_worker_internals_ui.cc
index e75f45f5f8a076b1cd200b2e5b64f558ca50f9e8..39fa2df3297767d0b30a44c112c1b8f57c03540f 100644
--- a/content/browser/service_worker/service_worker_internals_ui.cc
+++ b/content/browser/service_worker/service_worker_internals_ui.cc
@@ -84,12 +84,13 @@ class ServiceWorkerInternalsUI::OperationProxy
const scoped_refptr<ServiceWorkerRegistration>& registration);
void InspectActiveWorker(
- const base::FilePath& context_path,
+ const ServiceWorkerContextCore* const service_worker_context,
ServiceWorkerStatusCode status,
const scoped_refptr<ServiceWorkerRegistration>& registration);
- void InspecteWorkerOnUIThread(const base::FilePath& context_path,
- int64 version_id);
+ void InspecteWorkerOnUIThread(
+ const ServiceWorkerContextCore* const service_worker_context,
+ int64 version_id);
WeakPtr<ServiceWorkerInternalsUI> internals_;
scoped_ptr<ListValue> original_args_;
@@ -487,7 +488,7 @@ void ServiceWorkerInternalsUI::OperationProxy::InspectWorkerOnIOThread(
scope,
base::Bind(&ServiceWorkerInternalsUI::OperationProxy::InspectActiveWorker,
this,
- context->context()->storage_partition_path()));
+ context->context()));
}
namespace {
@@ -648,7 +649,7 @@ void ServiceWorkerInternalsUI::OperationProxy::DispatchSyncEventToActiveWorker(
}
void ServiceWorkerInternalsUI::OperationProxy::InspectActiveWorker(
- const base::FilePath& context_path,
+ const ServiceWorkerContextCore* const service_worker_context,
ServiceWorkerStatusCode status,
const scoped_refptr<ServiceWorkerRegistration>& registration) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
@@ -658,7 +659,7 @@ void ServiceWorkerInternalsUI::OperationProxy::InspectActiveWorker(
FROM_HERE,
base::Bind(&OperationProxy::InspecteWorkerOnUIThread,
this,
- context_path,
+ service_worker_context,
registration->active_version()->version_id()));
return;
}
@@ -667,12 +668,13 @@ void ServiceWorkerInternalsUI::OperationProxy::InspectActiveWorker(
}
void ServiceWorkerInternalsUI::OperationProxy::InspecteWorkerOnUIThread(
- const base::FilePath& context_path,
+ const ServiceWorkerContextCore* const service_worker_context,
int64 version_id) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
scoped_refptr<DevToolsAgentHost> agent_host(
EmbeddedWorkerDevToolsManager::GetInstance()
- ->GetDevToolsAgentHostForServiceWorker(context_path, version_id));
+ ->GetDevToolsAgentHostForServiceWorker(service_worker_context,
+ version_id));
if (agent_host) {
DevToolsManagerImpl::GetInstance()->Inspect(
internals_->web_ui()->GetWebContents()->GetBrowserContext(),

Powered by Google App Engine
This is Rietveld 408576698