content/browser/service_worker/service_worker_version.cc - Issue 261753008: Call EmbeddedWorkerDevToolsManager::ServiceWorkerCreated, WorkerContextStarted and WorkerDestroyed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 261753008: Call EmbeddedWorkerDevToolsManager::ServiceWorkerCreated, WorkerContextStarted and WorkerDestroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call WorkerDestroyed in ServiceWorkerCreated when it is not called correctly before. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/embedded_worker_registry.cc ('K') | « content/browser/service_worker/service_worker_context_core.cc ('k') | content/common/service_worker/embedded_worker_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.cc

diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc

index 66ca8830756abe28ea8e8b848c9ece3a822a8e9d..bb870f14ae72188fa165dc00b3e20926a3c06729 100644

--- a/content/browser/service_worker/service_worker_version.cc

+++ b/content/browser/service_worker/service_worker_version.cc

@@ -96,7 +96,7 @@ ServiceWorkerVersion::ServiceWorkerVersion(

scope_ = registration->pattern();

}

context_->AddLiveVersion(this);

- embedded_worker_ = context_->embedded_worker_registry()->CreateWorker();

+ embedded_worker_ = context_->embedded_worker_registry()->CreateWorker(scope_);

embedded_worker_->AddListener(this);

}

@@ -160,7 +160,6 @@ void ServiceWorkerVersion::StartWorkerWithCandidateProcesses(

if (running_status() == STOPPED) {

embedded_worker_->Start(

version_id_,

- scope_,

script_url_,

possible_process_ids,

base::Bind(&ServiceWorkerVersion::RunStartWorkerCallbacksOnError,