content/browser/service_worker/service_worker_browsertest.cc - Issue 261753008: Call EmbeddedWorkerDevToolsManager::ServiceWorkerCreated, WorkerContextStarted and WorkerDestroyed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 261753008: Call EmbeddedWorkerDevToolsManager::ServiceWorkerCreated, WorkerContextStarted and WorkerDestroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call WorkerDestroyed in ServiceWorkerCreated when it is not called correctly before. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/embedded_worker_registry.cc ('K') | « content/browser/service_worker/embedded_worker_registry.cc ('k') | content/browser/service_worker/service_worker_context_core.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index 9b32308834d8ab6af7025470268d24cf63fe0136..b73bf13ea3e6e3bafb415892a67875b9619ba976 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -154,14 +154,15 @@ class EmbeddedWorkerBrowserTest : public ServiceWorkerBrowserTest,

void StartOnIOThread() {

ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));

- worker_ = wrapper()->context()->embedded_worker_registry()->CreateWorker();

+ const GURL scope = embedded_test_server()->GetURL("/*");

+ worker_ =

+ wrapper()->context()->embedded_worker_registry()->CreateWorker(scope);

EXPECT_EQ(EmbeddedWorkerInstance::STOPPED, worker_->status());

worker_->AddListener(this);

AssociateRendererProcessToWorker(worker_.get());

const int64 service_worker_version_id = 33L;

- const GURL scope = embedded_test_server()->GetURL("/*");

const GURL script_url = embedded_test_server()->GetURL(

"/service_worker/worker.js");

std::vector<int> processes;

@@ -169,7 +170,6 @@ class EmbeddedWorkerBrowserTest : public ServiceWorkerBrowserTest,

shell()->web_contents()->GetRenderProcessHost()->GetID());

worker_->Start(

service_worker_version_id,

- scope,

script_url,

processes,

base::Bind(&EmbeddedWorkerBrowserTest::StartOnIOThread2, this));