Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 261753002: ozone: Split internal platforms into separate static_library targets (Closed)

Created:
6 years, 7 months ago by spang
Modified:
6 years, 7 months ago
Reviewers:
rjkroege
CC:
chromium-reviews, rjkroege, kalyank, stevenjb+watch_chromium.org, oshima+watch_chromium.org, ozone-reviews_chromium.org
Visibility:
Public.

Description

ozone: Split internal platforms into separate static_library targets This cleans up ozone.gyp so that each platform has its own include file and static_library target. BUG=368933 TEST=content_shell --ozone-platform=test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267677

Patch Set 1 #

Patch Set 2 : rebase w/o chromeos platform #

Patch Set 3 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -77 lines) Patch
M build/common.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/ozone.gyp View 1 2 5 chunks +24 lines, -56 lines 0 comments Download
M ui/ozone/platform/caca/caca.gypi View 2 chunks +23 lines, -12 lines 0 comments Download
A ui/ozone/platform/dri/dri.gypi View 1 1 chunk +59 lines, -0 lines 0 comments Download
A + ui/ozone/platform/test/test.gypi View 1 chunk +14 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
spang
6 years, 7 months ago (2014-05-01 00:41:27 UTC) #1
rjkroege
very nice cleanup. lgtm
6 years, 7 months ago (2014-05-01 14:27:33 UTC) #2
spang
The CQ bit was checked by spang@chromium.org
6 years, 7 months ago (2014-05-01 18:49:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/261753002/40001
6 years, 7 months ago (2014-05-01 18:49:54 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 00:00:18 UTC) #5
Message was sent while issue was closed.
Change committed as 267677

Powered by Google App Engine
This is Rietveld 408576698