Issue 2617513004: Revert "Added isolate + thread high watermark tracking to Observatory"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2617513004: Revert "Added isolate + thread high watermark tracking to Observatory" (Closed)

Created:
3 years, 11 months ago by bkonyi

Modified:
3 years, 11 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Added isolate + thread high watermark tracking to Observatory" This reverts commit c84f30741c90d040254767ff769a40d2cba3fb1a. TBR=johnmccutchan@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ffda8017915a4f0f7865616931c40d7fb0cde25c

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -124 lines)			Patch
M	runtime/observatory/lib/src/elements/isolate_view.dart	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	runtime/observatory/lib/src/models/objects/isolate.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/observatory/lib/src/models/objects/thread.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/observatory/lib/src/service/object.dart	View	4 chunks	+2 lines, -11 lines	0 comments	Download
M	runtime/observatory/tests/service/get_zone_memory_info_rpc_test.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/vm/isolate.h	View	3 chunks	+1 line, -6 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	5 chunks	+1 line, -15 lines	0 comments	Download
M	runtime/vm/thread.h	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	runtime/vm/thread.cc	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/thread_registry.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/thread_registry.cc	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	runtime/vm/thread_test.cc	View	2 chunks	+3 lines, -14 lines	0 comments	Download
M	runtime/vm/zone.cc	View	2 chunks	+0 lines, -11 lines	0 comments	Download

Total messages: 2 (1 generated)

bkonyi

3 years, 11 months ago (2017-01-04 23:21:46 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ffda8017915a4f0f7865616931c40d7fb0cde25c (presubmit successful).