Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2617483007: Extract code from dependency_grapher.dart for easier re-use elsewhere in the front end. (Closed)

Created:
3 years, 11 months ago by Paul Berry
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract code from dependency_grapher.dart for easier re-use elsewhere in the front end. In the process I've made the constructors for Graph, LibraryCycleNode, and LibraryNode public. I don't think this should be a problem, since these are simple data structures, so there is no harm in allowing clients to create them. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/1d57e1b09689d5e43010ccdcd3eb369e66b702e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -181 lines) Patch
M pkg/front_end/lib/dependency_grapher.dart View 4 chunks +5 lines, -132 lines 0 comments Download
A + pkg/front_end/lib/src/dependency_grapher_impl.dart View 5 chunks +11 lines, -49 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 11 months ago (2017-01-06 18:45:20 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 11 months ago (2017-01-06 19:32:31 UTC) #3
Paul Berry
3 years, 11 months ago (2017-01-06 19:37:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1d57e1b09689d5e43010ccdcd3eb369e66b702e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698