Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: third_party/WebKit/public/web/WebPlugin.h

Issue 2617443002: Implement ThreadedInputConnection.deleteSurroundingTextInCodePoints() (Closed)
Patch Set: Add more comments Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebPlugin.h
diff --git a/third_party/WebKit/public/web/WebPlugin.h b/third_party/WebKit/public/web/WebPlugin.h
index f9a488669051858c6e5a0c5aeffc0a9a98961de7..9cbce9e52394900a3dab67ea7fa64b0c3593c065 100644
--- a/third_party/WebKit/public/web/WebPlugin.h
+++ b/third_party/WebKit/public/web/WebPlugin.h
@@ -193,8 +193,14 @@ class WebPlugin {
// before and after the selection or caret.
virtual void extendSelectionAndDelete(int before, int after) {}
// Deletes text before and after the current cursor position, excluding the
- // selection.
+ // selection. The lengths are supplied in Java chars, not in code points or in
+ // glyphs.
virtual void deleteSurroundingText(int before, int after) {}
+ // Deletes text before and after the current cursor position, excluding the
+ // selection. The lengths are supplied in code points, not in Java chars or in
+ // glyphs. Do nothing if there are one or more invalid surrogate pairs in the
+ // requested range.
+ virtual void deleteSurroundingTextInCodePoints(int before, int after) {}
// If the given position is over a link, returns the absolute url.
// Otherwise an empty url is returned.
virtual WebURL linkAtPosition(const WebPoint& position) const {

Powered by Google App Engine
This is Rietveld 408576698