Chromium Code Reviews Chromium Code Reviews
Issue 2617443002:
Implement ThreadedInputConnection.deleteSurroundingTextInCodePoints() (Closed)
| Index: content/renderer/render_view_browsertest.cc |
| diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc |
| index f2fc1de6575015c3d6b842a17719bdc84e879f87..4d3bce0c81ac189c34bcc808e14147827e092245 100644 |
| --- a/content/renderer/render_view_browsertest.cc |
| +++ b/content/renderer/render_view_browsertest.cc |
| @@ -1666,6 +1666,53 @@ TEST_F(RenderViewImplTest, OnDeleteSurroundingText) { |
| EXPECT_EQ(0, info.selectionEnd); |
| } |
| +TEST_F(RenderViewImplTest, OnDeleteSurroundingTextInCodePoints) { |
| + // Load an HTML page consisting of an input field. |
| + LoadHTML( |
| + "<html>" |
| + "<head>" |
| + "</head>" |
| + "<body>" |
| + "<input id=\"test1\" value=\"abcdefghijklmnopqrstuvwxyz\"></input>" |
|
Changwan Ryu
2017/01/11 02:00:27
please use an example that has a surrogate pair.
yabinh
2017/01/24 11:39:56
Done.
|
| + "</body>" |
| + "</html>"); |
| + ExecuteJavaScriptForTests("document.getElementById('test1').focus();"); |
| + |
| + frame()->SetEditableSelectionOffsets(10, 10); |
| + frame()->DeleteSurroundingTextInCodePoints(3, 4); |
| + blink::WebTextInputInfo info = view()->webview()->textInputInfo(); |
| + EXPECT_EQ("abcdefgopqrstuvwxyz", info.value); |
| + EXPECT_EQ(7, info.selectionStart); |
| + EXPECT_EQ(7, info.selectionEnd); |
| + |
| + frame()->SetEditableSelectionOffsets(4, 8); |
| + frame()->DeleteSurroundingTextInCodePoints(2, 5); |
| + info = view()->webview()->textInputInfo(); |
| + EXPECT_EQ("abefgouvwxyz", info.value); |
| + EXPECT_EQ(2, info.selectionStart); |
| + EXPECT_EQ(6, info.selectionEnd); |
| + |
| + frame()->SetEditableSelectionOffsets(5, 5); |
| + frame()->DeleteSurroundingTextInCodePoints(10, 0); |
| + info = view()->webview()->textInputInfo(); |
| + EXPECT_EQ("ouvwxyz", info.value); |
| + EXPECT_EQ(0, info.selectionStart); |
| + EXPECT_EQ(0, info.selectionEnd); |
| + |
| + frame()->DeleteSurroundingTextInCodePoints(0, 10); |
| + info = view()->webview()->textInputInfo(); |
| + EXPECT_EQ("", info.value); |
| + EXPECT_EQ(0, info.selectionStart); |
| + EXPECT_EQ(0, info.selectionEnd); |
| + |
| + frame()->DeleteSurroundingTextInCodePoints(10, 10); |
| + info = view()->webview()->textInputInfo(); |
| + EXPECT_EQ("", info.value); |
| + |
| + EXPECT_EQ(0, info.selectionStart); |
| + EXPECT_EQ(0, info.selectionEnd); |
| +} |
| + |
| // Test that the navigating specific frames works correctly. |
| TEST_F(RenderViewImplTest, NavigateSubframe) { |
| // Load page A. |
