Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2876)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 2617443002: Implement ThreadedInputConnection.deleteSurroundingTextInCodePoints() (Closed)
Patch Set: Address dcheng@'s review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/test/test_render_frame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index 90e361c9267369721ebe677d5976c1e389f999ee..38e418b61d263c19cee3bb729e72169ac78c7f41 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -1670,6 +1670,31 @@ TEST_F(RenderViewImplTest, OnDeleteSurroundingText) {
EXPECT_EQ(0, info.selectionEnd);
}
+TEST_F(RenderViewImplTest, OnDeleteSurroundingTextInCodePoints) {
+ // Load an HTML page consisting of an input field.
+ LoadHTML(
+ // "ab" + trophy + space + "cdef" + trophy + space + "gh".
+ "<input id=\"test1\" value=\"ab&#x1f3c6; cdef&#x1f3c6; gh\">");
+ ExecuteJavaScriptForTests("document.getElementById('test1').focus();");
+
+ frame()->SetEditableSelectionOffsets(4, 4);
+ frame()->DeleteSurroundingTextInCodePoints(2, 2);
+ blink::WebInputMethodController* controller =
+ frame()->GetWebFrame()->inputMethodController();
+ blink::WebTextInputInfo info = controller->textInputInfo();
+ // "a" + "def" + trophy + space + "gh".
+ EXPECT_EQ(WebString::fromUTF8("adef\xF0\x9F\x8F\x86 gh"), info.value);
+ EXPECT_EQ(1, info.selectionStart);
+ EXPECT_EQ(1, info.selectionEnd);
+
+ frame()->SetEditableSelectionOffsets(1, 3);
+ frame()->DeleteSurroundingTextInCodePoints(1, 4);
+ info = controller->textInputInfo();
+ EXPECT_EQ("deh", info.value);
+ EXPECT_EQ(0, info.selectionStart);
+ EXPECT_EQ(2, info.selectionEnd);
+}
+
// Test that the navigating specific frames works correctly.
TEST_F(RenderViewImplTest, NavigateSubframe) {
// Load page A.
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/test/test_render_frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698