Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: third_party/WebKit/public/web/WebLocalFrame.h

Issue 2617443002: Implement ThreadedInputConnection.deleteSurroundingTextInCodePoints() (Closed)
Patch Set: Don't convert utf8 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebLocalFrame.h
diff --git a/third_party/WebKit/public/web/WebLocalFrame.h b/third_party/WebKit/public/web/WebLocalFrame.h
index 31919e7d86acd39f19a9f51d9be18175eac62761..390def30b55a5ac48ac6fe9ee70dbbdf5af6a013 100644
--- a/third_party/WebKit/public/web/WebLocalFrame.h
+++ b/third_party/WebKit/public/web/WebLocalFrame.h
@@ -323,8 +323,14 @@ class WebLocalFrame : public WebFrame {
// Replaces the selection with the input string.
virtual void replaceSelection(const WebString&) = 0;
// Deletes text before and after the current cursor position, excluding the
- // selection.
+ // selection. The lengths are supplied in Java chars, not in code points or in
yosin_UTC9 2017/02/09 07:19:28 s/Java chars/UTF-16 Code Unit/ Blink doesn't know
yabinh 2017/02/09 10:37:04 Done.
+ // glyphs.
virtual void deleteSurroundingText(int before, int after) = 0;
+ // A variant of deleteSurroundingText(int, int). Major differences are:
+ // 1. The lengths are supplied in code points, not in Java chars or in glyphs.
yosin_UTC9 2017/02/09 07:19:28 s/Java chars/UTF-16 Code Unit/ Blink doesn't know
yabinh 2017/02/09 10:37:04 Done.
+ // 2. This method does nothing if there are one or more invalid surrogate
+ // pairs in the requested range.
+ virtual void deleteSurroundingTextInCodePoints(int before, int after) = 0;
virtual void extractSmartClipData(WebRect rectInViewport,
WebString& clipText,

Powered by Google App Engine
This is Rietveld 408576698